-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade to Angular 19 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95cbda0
Upgrade to Angular 18
XanderVertegaal 4d5542a
Disable SSR
XanderVertegaal e55a092
Update to Angular 19
XanderVertegaal dd5458b
Update dependencies, remove NgRx
XanderVertegaal 21ac980
Remove deprecated Hrefs; update import
XanderVertegaal dbb410f
Use new template syntax
XanderVertegaal e37e50a
Add debug logging
XanderVertegaal 91e4d72
Merge branch 'develop' into feature/upgrade-ng-18
XanderVertegaal 7353091
Return baseHref
XanderVertegaal 7a346f8
Re-remove baseHref
XanderVertegaal f196983
Debug logging
XanderVertegaal 3608feb
add launch.json for debugging
Meesch a4d1b74
Fix github action functional test
Meesch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Python Debugger: Current File", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "program": "${file}", | ||
| "console": "integratedTerminal" | ||
| }, | ||
| { | ||
| "name": "Python Debugger: Pytest Functional Tests", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "module": "pytest", | ||
| "args": ["functional-tests"], | ||
| "console": "integratedTerminal" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,9 +23,7 @@ | |
| "outputPath": "dist", | ||
| "index": "src/index.html", | ||
| "browser": "src/main.ts", | ||
| "polyfills": [ | ||
| "zone.js" | ||
| ], | ||
| "polyfills": ["zone.js", "@angular/localize/init"], | ||
| "tsConfig": "tsconfig.app.json", | ||
| "inlineStyleLanguage": "scss", | ||
| "assets": [ | ||
|
|
@@ -49,9 +47,7 @@ | |
| "scripts": [], | ||
| "server": "src/main.server.ts", | ||
| "prerender": true, | ||
| "ssr": { | ||
| "entry": "server.ts" | ||
| }, | ||
| "ssr": false, | ||
| "baseHref": "/" | ||
| }, | ||
| "configurations": { | ||
|
|
@@ -77,9 +73,7 @@ | |
| "sourceMap": true | ||
| }, | ||
| "nl": { | ||
| "localize": [ | ||
| "nl" | ||
| ] | ||
| "localize": ["nl"] | ||
| } | ||
| }, | ||
| "defaultConfiguration": "production" | ||
|
|
@@ -109,17 +103,16 @@ | |
| "format": "xlf", | ||
| "outputPath": "locale", | ||
| "includeContext": true, | ||
| "targetFiles": [ | ||
| "messages.nl.xlf" | ||
| ] | ||
| "targetFiles": ["messages.nl.xlf"] | ||
| } | ||
| }, | ||
| "test": { | ||
| "builder": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "polyfills": [ | ||
| "zone.js", | ||
| "zone.js/testing" | ||
| "zone.js/testing", | ||
| "@angular/localize/init" | ||
| ], | ||
| "tsConfig": "tsconfig.spec.json", | ||
| "inlineStyleLanguage": "scss", | ||
|
|
@@ -128,26 +121,22 @@ | |
| "src/favicon.svg", | ||
| "src/assets" | ||
| ], | ||
| "styles": [ | ||
| "src/styles.scss" | ||
| ], | ||
| "styles": ["src/styles.scss"], | ||
| "scripts": [], | ||
| "karmaConfig": "karma.conf.js" | ||
| } | ||
| } | ||
| }, | ||
| "i18n": { | ||
| "sourceLocale": { | ||
| "code": "en", | ||
| "baseHref": "/en/" | ||
| "code": "en" | ||
| }, | ||
| "locales": { | ||
| "nl": { | ||
| "translation": "locale/messages.nl.xlf", | ||
| "baseHref": "/nl/" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leaving |
||
| "translation": "locale/messages.nl.xlf" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,60 @@ | ||
| { | ||
| "name": "langpro-annotator", | ||
| "scripts": { | ||
| "start": "yarn serve", | ||
| "build": "ng build --base-href=/static/ --localize", | ||
| "watch": "ng build --watch", | ||
| "test": "ng test --watch=true", | ||
| "serve:ssr:langpro-annotator": "node dist/langpro-annotator/server/server.mjs", | ||
| "prebuild": "node ./build/build-pre.js", | ||
| "i18n": "ng extract-i18n --output-path locale", | ||
| "preserve": "yarn prebuild", | ||
| "serve": "ng serve", | ||
| "serve:en": "ng serve --configuration=en", | ||
| "serve:nl": "ng serve --configuration=nl", | ||
| "stop": "lsof -t -i tcp:4200 | xargs kill -9 || echo \"not running\"", | ||
| "pretest": "yarn prebuild", | ||
| "test-once": "ng test --watch=false" | ||
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular/animations": "^17.3.0", | ||
| "@angular/common": "^17.3.0", | ||
| "@angular/compiler": "^17.3.0", | ||
| "@angular/core": "^17.3.0", | ||
| "@angular/forms": "^17.3.0", | ||
| "@angular/platform-browser": "^17.3.0", | ||
| "@angular/platform-browser-dynamic": "^17.3.0", | ||
| "@angular/platform-server": "^17.3.0", | ||
| "@angular/router": "^17.3.0", | ||
| "@angular/ssr": "^17.3.13", | ||
| "@fortawesome/angular-fontawesome": "^0.14.1", | ||
| "@fortawesome/fontawesome-svg-core": "^6.5.2", | ||
| "@fortawesome/free-solid-svg-icons": "^6.5.2", | ||
| "@ng-bootstrap/ng-bootstrap": "^16.0.0", | ||
| "@ngrx/effects": "^17.2.0", | ||
| "@ngrx/store": "^17.2.0", | ||
| "@popperjs/core": "^2.11.8", | ||
| "bootstrap": "^5.3.3", | ||
| "colors": "^1.4.0", | ||
| "express": "^4.18.2", | ||
| "rxjs": "~7.8.0", | ||
| "tslib": "^2.3.0", | ||
| "zone.js": "~0.14.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "^17.3.13", | ||
| "@angular/cli": "^17.3.13", | ||
| "@angular/compiler-cli": "^17.3.0", | ||
| "@angular/localize": "17.3.12", | ||
| "@types/express": "^4.17.17", | ||
| "@types/jasmine": "~5.1.0", | ||
| "@types/node": "^18.18.0", | ||
| "jasmine-core": "~5.1.0", | ||
| "karma": "~6.4.0", | ||
| "karma-chrome-launcher": "~3.2.0", | ||
| "karma-coverage": "~2.2.0", | ||
| "karma-jasmine": "~5.1.0", | ||
| "karma-jasmine-html-reporter": "~2.1.0", | ||
| "ng-extract-i18n-merge": "^2.12.0", | ||
| "typescript": "~5.4.2" | ||
| } | ||
| } | ||
| "name": "langpro-annotator", | ||
| "scripts": { | ||
| "start": "yarn serve", | ||
| "build": "ng build --base-href=/static/ --localize", | ||
| "watch": "ng build --watch", | ||
| "test": "ng test --watch=true", | ||
| "serve:ssr:langpro-annotator": "node dist/langpro-annotator/server/server.mjs", | ||
| "prebuild": "node ./build/build-pre.js", | ||
| "i18n": "ng extract-i18n --output-path locale", | ||
| "preserve": "yarn prebuild", | ||
| "serve": "ng serve", | ||
| "serve:en": "ng serve --configuration=en", | ||
| "serve:nl": "ng serve --configuration=nl", | ||
| "stop": "lsof -t -i tcp:4200 | xargs kill -9 || echo \"not running\"", | ||
| "pretest": "yarn prebuild", | ||
| "test-once": "ng test --watch=false" | ||
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular/animations": "^19.2.13", | ||
| "@angular/common": "^19.2.13", | ||
| "@angular/compiler": "^19.2.13", | ||
| "@angular/core": "^19.2.13", | ||
| "@angular/forms": "^19.2.13", | ||
| "@angular/platform-browser": "^19.2.13", | ||
| "@angular/platform-browser-dynamic": "^19.2.13", | ||
| "@angular/platform-server": "^19.2.13", | ||
| "@angular/router": "^19.2.13", | ||
| "@angular/ssr": "^19.2.13", | ||
| "@fortawesome/angular-fontawesome": "^1.0.0", | ||
| "@fortawesome/fontawesome-svg-core": "^6.7.2", | ||
| "@fortawesome/free-solid-svg-icons": "^6.7.2", | ||
| "@ng-bootstrap/ng-bootstrap": "^18.0.0", | ||
| "@popperjs/core": "^2.11.8", | ||
| "bootstrap": "^5.3.3", | ||
| "colors": "^1.4.0", | ||
| "express": "^4.18.2", | ||
| "rxjs": "~7.8.0", | ||
| "tslib": "^2.3.0", | ||
| "zone.js": "~0.15.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "^19.2.13", | ||
| "@angular/cli": "^19.2.13", | ||
| "@angular/compiler-cli": "^19.2.13", | ||
| "@angular/localize": "19.2.13", | ||
| "@types/express": "^4.17.17", | ||
| "@types/jasmine": "~5.1.0", | ||
| "@types/node": "^18.18.0", | ||
| "jasmine-core": "~5.1.0", | ||
| "karma": "~6.4.0", | ||
| "karma-chrome-launcher": "~3.2.0", | ||
| "karma-coverage": "~2.2.0", | ||
| "karma-jasmine": "~5.1.0", | ||
| "karma-jasmine-html-reporter": "~2.1.0", | ||
| "ng-extract-i18n-merge": "^2.12.0", | ||
| "typescript": "~5.8.3" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to keep those print statements, maybe add an
if settings.DEBUGThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these are simply for debugging purposes to find out why the tests are failing. I cannot run the functional tests locally on my machine, so I have to debug on GitHub (which is not ideal).
If you can run the functional tests on your machine, would you be able to help debugging this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm concerned, feel free to rip out the existing functional test code. When we're ready to write tests, I'd like to use playwright (see https://github.com/CentreForDigitalHumanities/ellp for an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Meesch is going to give it his best shot. If not, we will rip and tear until it is done.