Feature/frontend permissions#76
Merged
Merged
Conversation
XanderVertegaal
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the frontend allows users to do what they are allowed to, according to the roles and permissions in the permission matrix (see README.md in #75).
can_copy_problemandcan_add_label_annotationsto govern button visibility in the frontend.add_labelannotationonly, and thechange_labelannotationpermission is removed. There is no difference between the two, so this felt simpler, but let me know if you disagree or think I should renameadd_labelannotationinstead.