Integration with parser backend by jgonggrijp · Pull Request #77 · CentreForDigitalHumanities/langpro-annotator

jgonggrijp · 2026-03-06T02:06:03Z

This branch continues and supersedes the work in #51. Merging this PR will also merge #51 as a side effect.

The changes in this branch depend on https://github.com/CentreForDigitalHumanities/langpro-container/pull/4. The langpro-container is added as a git submodule.

As discussed last Tuesday with @XanderVertegaal and @kovvalsky, the container has been slightly adapted to also respond with JSONified nltk.Tree-ified proofs in non-raw mode. The JSONified nltk.Trees lack labeling of tree components; all structure beyond basic subtree nesting is implicitly encoded in the string label of each node. We will initially work with the raw node labels without parsing them, which in some places may require simplifying the visualizations. As further discussed with @XanderVertegaal, this branch does not yet attempt to actually render these data, but merely ensures that an actual request is made to the container and that its response is delivered to the right components.

The frontend/src/app/tree.ts and all modules under frontend/src/app/annotate/parse-tree, which were added in #51, are now effectively dead code and should be removed eventually. You can safely ignore them in review.

I have not made any effort yet to pipe the response to the proof tableau components; I will do this in a follow-up branch.

Please review this in whatever way makes the most sense to you. I will comment on a few details in advance.

…ature/parse-interface-ctd

…rser

Instead of handling it in the input component.

jgonggrijp · 2026-03-06T02:09:51Z

+    private destroyRef = inject(DestroyRef);
+    private parseService = inject(ParseService);
+
+    public parseResults = mockResult;


I left the initialization with the mockResult for now, because it provides a simple visual confirmation that the response from the container is actually fed to this component. When you press the "Parse and prove" button, the parse tables disappear (with a delay because the response arrives with a delay). This is because the CCG trees are in a format that the component has not been adapted to yet.

jgonggrijp · 2026-03-06T02:14:29Z

+        this.parseService.parse$
+            .pipe(takeUntilDestroyed(this.destroyRef))
+            .subscribe((response) => {
+                console.log("Parse response:", response);
+                this.parseResults = response.data.ccg_trees;
+            });


It would probably be better to do something like

Suggested change

this.parseService.parse$

.pipe(takeUntilDestroyed(this.destroyRef))

.subscribe((response) => {

console.log("Parse response:", response);

this.parseResults = response.data.ccg_trees;

});

this.parseResults$ = this.parseService.parse$

.pipe(takeUntilDestroyed(this.destroyRef))

.pipe(map((response) => response.data.ccg_trees));

and then write @let parseResults = parseResults$ | async in the template. I leave this up to you, when you adapt the component to the actual format of the data.

XanderVertegaal

The code looks fine, and I'm happy you got everything going!

Locally, I'm running into ModuleNotFoundErrors, but I will contact you separate about this. I suspect this has to do with my local setup, not with the code changes proposed in this PR.

XanderVertegaal · 2026-03-09T10:38:04Z

+import { Component, DestroyRef, inject, OnInit } from "@angular/core";
+import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
 import { mockResult } from "./mockParseResult";
+import { ParseResponse, ParseService } from "@/services/parse.service";


Unused import.

Suggested change

import { ParseResponse, ParseService } from "@/services/parse.service";

import { ParseService } from "@/services/parse.service";

XanderVertegaal · 2026-03-09T10:42:04Z

 import { AnnotationMenuComponent } from "./annotation-menu/annotation-menu.component";
 import { NavigatorComponent } from "./navigator/navigator.component";
-import { AnnotationInputComponent } from "./annotation-input/annotation-input.component";
+import { AnnotationInputComponent, ParseInput } from "./annotation-input/annotation-input.component";


Suggested change

import { AnnotationInputComponent, ParseInput } from "./annotation-input/annotation-input.component";

import { AnnotationInputComponent } from "./annotation-input/annotation-input.component";

XanderVertegaal · 2026-03-09T10:44:04Z

 import { Subject, switchMap, catchError, of } from 'rxjs';
 import { ParseInput } from '@/annotate/annotation-input/annotation-input.component';

+export type ParseResponse = any;


I assume that this is a placeholder for when we actually define the expected output from the parser (in a future PR).

This is what @bbonf originally wrote. I made the same assumption as you did.

XanderVertegaal · 2026-03-09T10:51:46Z

    "colors": "^1.4.0",
    "express": "^4.18.2",
    "rxjs": "~7.8.0",
+    "svg-pan-zoom": "bumbu/svg-pan-zoom",


Is there a reason to refer to the Git repo instead of the NPM registry (with e.g. "svg-pan-zoom": "^3.6.2") for this package?

Ah, I should actually be asking @bbonf about this, I think :)

XanderVertegaal · 2026-03-09T12:52:06Z

@@ -0,0 +1,3 @@
+[submodule "langpro-container"]
+	path = langpro-container
+	url = git@github.com:CentreForDigitalHumanities/langpro-container.git


The SSH approach did not work with me. (I got permission errors with my public key.) Using HTTPS as follows fixed the issue.

url = https://github.com/CentreForDigitalHumanities/langpro-container.git

Should I look into fixing my SSH public key, or can we adopt HTTPS?

I think you need to ask @tymees for help. If I'm right, the repository now belongs to our team. I'm able to sync using SSH so in theory, so should you.

Actually, I now realize that the SSH URL might lead to problems in CI and deployment. I'll change it to https.

@XanderVertegaal If you actually have problems with your SSH key, I of course still recommend that you address those. SSH is easier for syncing because you don't need to reauthenticate periodically.

@XanderVertegaal

After a remark by @XanderVertegaal in #77

@XanderVertegaal

This was my own omission in 9774833. Heads-up @XanderVertegaal

bbonf and others added 20 commits October 9, 2025 09:52

preliminary working integration with parser backend

6793239

pan/zoom support for svg tree

a1f8b29

added format param

1af367c

multiple ccg trees

19e7f5e

refactored parse tree and data types

2174cd3

Merge branch 'develop' into feature/parse-interface

d5195f8

Add langpro-container as submodule

b96ce66

Use submodule langpro-container in docker-compose setup

3d182d9

Fix whitespace in frontend/tsconfig.json

c4e06d9

added missing tree.ts to repo

e57c1f3

Merge remote-tracking branch 'origin/feature/parse-interface' into fe…

b0cb415

…ature/parse-interface-ctd

Fix typo in docker-compose.yml: LANGRPO -> LANGPRO

de7919b

Use container port for in-Docker network requests

74c5a58

Actually log what is being sent to the parser in ParseView.send_to_pa…

b7c00ac

…rser

Use latest langpro-container on langpro-submodule branch

6bdf713

.gitignore ProofBank imports

7f40eed

Merge branch 'develop' into feature/parse-interface-ctd

9774833

Feed backend parse response into new frontend parse-results component

76b3396

Instead of handling it in the input component.

Upgrade to container version that includes proof in annotator mode

ec46c7b

Document the submodule situation

e206485

jgonggrijp requested a review from XanderVertegaal March 6, 2026 02:06

jgonggrijp commented Mar 6, 2026

View reviewed changes

XanderVertegaal approved these changes Mar 9, 2026

View reviewed changes

jgonggrijp added 2 commits March 9, 2026 16:45

Remove unused imports as suggested by @XanderVertegaal in review of #77

1d1ced5

Use HTTPS URL for the langpro-container submodule

83513ab

After a remark by @XanderVertegaal in #77

jgonggrijp merged commit 97ae97b into develop Mar 9, 2026
1 check failed

jgonggrijp deleted the feature/parse-interface-ctd branch March 9, 2026 16:25

jgonggrijp added a commit that referenced this pull request Mar 12, 2026

Fix missing providers in frontend tests (#77)

1f01702

This was my own omission in 9774833. Heads-up @XanderVertegaal

jgonggrijp mentioned this pull request Mar 17, 2026

Visualize the actual proofs of the current problem with the TableauSVG component #79

Merged

4 tasks

	import { ParseResponse, ParseService } from "@/services/parse.service";
	import { ParseService } from "@/services/parse.service";

	import { AnnotationInputComponent, ParseInput } from "./annotation-input/annotation-input.component";
	import { AnnotationInputComponent } from "./annotation-input/annotation-input.component";

Conversation

jgonggrijp commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XanderVertegaal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jgonggrijp commented Mar 6, 2026 •

edited

Loading