RDS reader#42
Merged
Merged
Conversation
Contributor
Author
|
@JeltevanBoheemen this and #43 were already in CentreForDigitalHumanities/Textcavator#1987, so unless you skipped reviewing those specific changes at the time, there's no need to review them again. |
JeltevanBoheemen
approved these changes
Jul 9, 2026
JeltevanBoheemen
left a comment
JeltevanBoheemen
left a comment
Contributor
There was a problem hiding this comment.
I will admit to thinking you misspelled RDF.
Good implementation.
|
|
||
| def data_from_file(self, path: str) -> Iterable[Dict]: | ||
| result = pyreadr.read_r(path) | ||
| data: pandas.DataFrame = result['data'] |
Contributor
There was a problem hiding this comment.
Good idea to provide a type annotation here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reader for extracting RDS (R data serialisation) files.