fix: Add .gitattributes to enforce LF line endings for Code Quality workflow#29
Merged
Merged
Conversation
…orkflow - Add .gitattributes to enforce LF line endings on all text files - This prevents CRLF/LF inconsistencies between Windows development and Linux CI - Normalize existing binary files (favicon.ico) - Fixes Black formatting differences in Code Quality workflow
- Reformat modbus_app/admin.py, tasks.py, serializers.py, views.py - Reformat modbus_webserver/asgi.py, urls.py - Fixes line ending inconsistencies between Windows and Linux - All files now consistently formatted with Black 24.3.0
- Fix import sorting in all Python files - Ensures consistent import order between Windows and Linux
- Apply Black and isort formatting with LF line endings - Fixes multi-line import formatting - Resolves Code Quality workflow failures
- Configure Black with line-length=120 and Python 3.11 target - Configure isort with black profile for compatibility - Apply consistent formatting across all Python files - Fixes Code Quality workflow by ensuring Black and isort agree on formatting
- Remove unused imports in tasks.py and tests.py - Fix f-string without placeholders in modbus_driver.py - Break long lines to under 120 characters - Add noqa comments for intentional E402 violations (imports after Django setup) - Fix bare except clauses in test_settings.py - Fixes Code Quality workflow Flake8 step
- Remove unused imports (database_sync_to_async, timezone, datetime, timedelta, Optional, ModbusException, Register) - Remove unused variables (e, result) - Convert f-strings without placeholders to regular strings - Fixes all remaining Code Quality workflow failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Code Quality workflow failures by enforcing consistent line endings.
Problem
The Code Quality workflow was failing because Black detected formatting differences between Windows development (CRLF line endings) and Linux CI (LF line endings). Even though files appeared correctly formatted locally, Black in CI would detect differences.
Solution
Impact
Checklist
Fixes line ending issues causing Code Quality workflow failures.