-
Notifications
You must be signed in to change notification settings - Fork 264
Add VectorTilesRasterOverlay
#1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8da5554
30bbd16
5f06efd
4a94e9e
997680e
c22f0b9
7be2262
b9f956b
99da4eb
9f152d1
2d158c2
537b608
224f7a5
0e0d06a
693eecd
94a0b9e
8e70bfb
2a1446f
f7ac37d
03dad83
11c4120
1eac54c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| #pragma once | ||
|
|
||
| #include "RasterOverlayUpsampler.h" | ||
|
|
||
| #include <Cesium3DTilesSelection/CesiumIonTilesetContentLoaderFactory.h> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer not to make I guess it's worth considering what is the actual separation of concerns here. Originally, there was no TilesetContentManager; everything was in Tileset. When Bao introduced the TilesetContentManager, he described it like this:
So the content manager handled tile content state transitions (loading/unloading, basically) and the Tileset handled the rest. Where "the rest" was mostly the selection algorithm and the public entry points to the content manager. Now with #1342, we're talking about moving the selection algorith out of Tileset, too. What's left? Not much I guess, but I think it's still serving a useful purpose as the public API representation of a Tileset, even if almost everything it does is delegated. By exposing TilesetContentManager, we a) need to give a lot more thought to its public API, because very little has gone into it, and b) are committing to maintaining it (yes, our deprecation policy doesn't strictly require we avoid breakage, but we still should avoid it wherever possibe). |
||
| #include <Cesium3DTilesSelection/RasterOverlayCollection.h> | ||
| #include <Cesium3DTilesSelection/RasterOverlayUpsampler.h> | ||
| #include <Cesium3DTilesSelection/Tile.h> | ||
| #include <Cesium3DTilesSelection/TileContent.h> | ||
| #include <Cesium3DTilesSelection/TilesetContentLoader.h> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // This file was generated by generate-classes. | ||
| // DO NOT EDIT THIS FILE! | ||
| #pragma once | ||
|
|
||
| #include <CesiumGltf/Library.h> | ||
| #include <CesiumUtility/ExtensibleObject.h> | ||
|
|
||
| #include <cstdint> | ||
|
|
||
| namespace CesiumGltf { | ||
| /** | ||
| * @brief glTF extension adding an encoding of polygon primitive topology | ||
| */ | ||
| struct CESIUMGLTF_API ExtensionExtMeshPolygon final | ||
| : public CesiumUtility::ExtensibleObject { | ||
| /** | ||
| * @brief The original name of this type. | ||
| */ | ||
| static constexpr const char* TypeName = "ExtensionExtMeshPolygon"; | ||
| /** @brief The official name of the extension. This should be the same as its | ||
| * key in the `extensions` object. */ | ||
| static constexpr const char* ExtensionName = "EXT_mesh_polygon"; | ||
|
|
||
| /** | ||
| * @brief Integer number of polygons encoded in the mesh primitive. | ||
| */ | ||
| int32_t count = -1; | ||
|
|
||
| /** | ||
| * @brief Index of an accessor containing indices of the polygons' exterior | ||
| * and interior loops. The accessor MUST have SCALAR type and an unsigned | ||
| * integer component type. | ||
| */ | ||
| int32_t loopIndices = -1; | ||
|
|
||
| /** | ||
| * @brief Index of an accessor containing one integer offset per polygon in | ||
| * the primitive, indicating the first index of the first linear ring | ||
| * associated with that polygon. | ||
| */ | ||
| int32_t loopIndicesOffsets = -1; | ||
|
|
||
| /** | ||
| * @brief Index of an accessor containing one integer offset per polygon in | ||
| * the primitive, indicating the first index of the first triangle associated | ||
| * with that polygon. | ||
| */ | ||
| int32_t indicesOffsets = -1; | ||
|
|
||
| /** | ||
| * @brief Calculates the size in bytes of this object, including the contents | ||
| * of all collections, pointers, and strings. This will NOT include the size | ||
| * of any extensions attached to the object. Calling this method may be slow | ||
| * as it requires traversing the object's entire structure. | ||
| */ | ||
| int64_t getSizeBytes() const { | ||
| int64_t accum = 0; | ||
| accum += int64_t(sizeof(ExtensionExtMeshPolygon)); | ||
| accum += CesiumUtility::ExtensibleObject::getSizeBytes() - | ||
| int64_t(sizeof(CesiumUtility::ExtensibleObject)); | ||
|
|
||
| return accum; | ||
| } | ||
| }; | ||
| } // namespace CesiumGltf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be used. The
Tilesetjust callsActivateRasterOverlay::tickdirectly.