Skip to content

Added KHR_billboard support#1376

Closed
david-lively wants to merge 4 commits into
mainfrom
billboard-extension
Closed

Added KHR_billboard support#1376
david-lively wants to merge 4 commits into
mainfrom
billboard-extension

Conversation

@david-lively

Copy link
Copy Markdown
Contributor

Description

Added support for KHR_billboard glTF extension.

Issue number or link

NA

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Remaining Tasks

NA

Testing plan

NA

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@david-lively david-lively marked this pull request as ready for review May 26, 2026 18:03
@j9liu j9liu self-requested a review June 22, 2026 17:13
@david-lively

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jun 22, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict in tools/generate-classes/glTF.json by keeping both the KHR_billboard entry from this branch and the EXT_mesh_polygon entry that was added to main. The branch is now up to date with main (commit 74a474ade).

@david-lively david-lively deleted the billboard-extension branch June 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants