fix: missing env vars for devnet deploy#63
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the healthcheck configuration in docker-compose.yml and introduces several new environment variables in env.py for semantic search, Canton ledger connectivity, and environment isolation. Feedback focuses on resolving inconsistent default values for ledger and server URLs and aligning boolean parsing logic for the isolation flag with existing helper functions.
| ENV_VALUES["CANTON_DEFAULT_PAYER_PARTY"] = os.getenv("CANTON_DEFAULT_PAYER_PARTY", "") | ||
|
|
||
| # Isolated environment flag (also read directly via os.environ at module level) | ||
| ENV_VALUES["IS_ISOLATED_ENVIRONMENT"] = os.getenv("IS_ISOLATED_ENVIRONMENT", "false") |
There was a problem hiding this comment.
Adding IS_ISOLATED_ENVIRONMENT to ENV_VALUES is necessary for the get_env helpers to function, but the parsing logic at the module level (line 19: .lower() == "true") is inconsistent with the get_env_bool helper (lines 162-174), which also accepts "1", "yes", and "on". This discrepancy can cause the server to incorrectly identify its environment type if values like "1" are used. Consider aligning the logic across the module.
1 participant
No description provided.