Skip to content

feat: reward marker emission#65

Merged
sqhell merged 3 commits into
mainfrom
fix/autobot-env-var
Apr 16, 2026
Merged

feat: reward marker emission#65
sqhell merged 3 commits into
mainfrom
fix/autobot-env-var

Conversation

@sqhell
Copy link
Copy Markdown
Contributor

@sqhell sqhell commented Apr 16, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Featured App Rewards system that emits activity markers on the Canton ledger following billable tool calls. Key additions include the featured_app_rewards.py module for managing reward contracts, integration of marker emission into the server's billing flow, and a log filter to reduce noise from health check probes. Additionally, logging for authorization validation and semantic search has been enhanced. Review feedback identifies critical bugs in the new rewards module where snake_case keys are used instead of the camelCase keys required by the Canton JSON API v2, and notes an inconsistency in the default similarity threshold value.

Comment thread src/canton_mcp_server/featured_app_rewards.py
Comment thread src/canton_mcp_server/featured_app_rewards.py
Comment thread src/canton_mcp_server/core/semantic_search.py
@sqhell sqhell merged commit 5aedfa1 into main Apr 16, 2026
3 checks passed
@sqhell sqhell deleted the fix/autobot-env-var branch April 16, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant