feat: metrics and reward handling#67
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces "Growth Mode" to the autobots simulation, enabling organic user growth modeling through persona-driven behaviors and a party pool system to manage Canton party limits. On the backend, it implements a pagination strategy for ledger updates to bypass the 200-element cap on active contract queries. Feedback identifies a potential crash risk when handling opaque ledger offsets as integers and performance bottlenecks caused by full ledger scans on every query. Additionally, corrections are needed for CLI argument parsing to allow zero values, and improvements are suggested for network request reliability and pagination efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.