Skip to content

feat: metrics and reward handling#67

Merged
sqhell merged 2 commits into
mainfrom
feat/metrics
Apr 23, 2026
Merged

feat: metrics and reward handling#67
sqhell merged 2 commits into
mainfrom
feat/metrics

Conversation

@sqhell
Copy link
Copy Markdown
Contributor

@sqhell sqhell commented Apr 23, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces "Growth Mode" to the autobots simulation, enabling organic user growth modeling through persona-driven behaviors and a party pool system to manage Canton party limits. On the backend, it implements a pagination strategy for ledger updates to bypass the 200-element cap on active contract queries. Feedback identifies a potential crash risk when handling opaque ledger offsets as integers and performance bottlenecks caused by full ledger scans on every query. Additionally, corrections are needed for CLI argument parsing to allow zero values, and improvements are suggested for network request reliability and pagination efficiency.

Comment thread src/canton_mcp_server/canton_billing.py
Comment thread src/canton_mcp_server/canton_billing.py
Comment thread autobots/runner.js Outdated
Comment thread autobots/provisioner.js Outdated
Comment thread src/canton_mcp_server/canton_billing.py Outdated
@sqhell sqhell merged commit a595c26 into main Apr 23, 2026
3 checks passed
@sqhell sqhell deleted the feat/metrics branch April 23, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant