-
Notifications
You must be signed in to change notification settings - Fork 1
fix: startup checks for autobot #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -61,6 +61,12 @@ def validate_startup_config() -> dict: | |||||||||||||||||
| raise SystemExit(msg) | ||||||||||||||||||
|
|
||||||||||||||||||
| # --- Step 2: ChromaDB path check --- | ||||||||||||||||||
| # Presence of a pre-built ChromaDB index is informational, not fatal. | ||||||||||||||||||
| # The CPU Dockerfile pre-indexes at build time, so production CPU images | ||||||||||||||||||
| # always have chroma.sqlite3 at boot. The GPU Dockerfile deliberately | ||||||||||||||||||
| # ships without an index — `server.py`'s warmup task creates the dir and | ||||||||||||||||||
| # indexes on the GPU at runtime (see `_warmup_semantic_search`). Either | ||||||||||||||||||
| # way, blocking boot here stops the warmup task from ever running. | ||||||||||||||||||
| chroma_dir = get_env("CHROMA_PERSIST_DIR", "") | ||||||||||||||||||
| if chroma_dir: | ||||||||||||||||||
| chroma_path = Path(chroma_dir) | ||||||||||||||||||
|
|
@@ -71,20 +77,16 @@ def validate_startup_config() -> dict: | |||||||||||||||||
| logger.info(f"ChromaDB index found at {chroma_dir}") | ||||||||||||||||||
| else: | ||||||||||||||||||
| readiness["chromadb_ready"] = False | ||||||||||||||||||
| msg = f"CHROMA_PERSIST_DIR={chroma_dir} exists but contains no chroma.sqlite3 — pre-built index missing" | ||||||||||||||||||
| if is_isolated: | ||||||||||||||||||
| logger.critical(msg) | ||||||||||||||||||
| raise SystemExit(msg) | ||||||||||||||||||
| else: | ||||||||||||||||||
| logger.warning(f"{msg} (will build on first request)") | ||||||||||||||||||
| logger.warning( | ||||||||||||||||||
| f"CHROMA_PERSIST_DIR={chroma_dir} exists but contains no chroma.sqlite3 — " | ||||||||||||||||||
| f"warmup task will build the index on first request" | ||||||||||||||||||
| ) | ||||||||||||||||||
| else: | ||||||||||||||||||
| readiness["chromadb_ready"] = False | ||||||||||||||||||
| msg = f"CHROMA_PERSIST_DIR={chroma_dir} does not exist" | ||||||||||||||||||
| if is_isolated: | ||||||||||||||||||
| logger.critical(msg) | ||||||||||||||||||
| raise SystemExit(msg) | ||||||||||||||||||
| else: | ||||||||||||||||||
| logger.warning(f"{msg} (will create on first request)") | ||||||||||||||||||
| logger.warning( | ||||||||||||||||||
| f"CHROMA_PERSIST_DIR={chroma_dir} does not exist — " | ||||||||||||||||||
| f"warmup task will create and populate it on first request" | ||||||||||||||||||
| ) | ||||||||||||||||||
|
Comment on lines
+86
to
+89
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the previous warning, the index creation and population happen in the background at startup via the warmup task, not 'on first request'. Updating this message ensures consistency with the actual server behavior.
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| # --- Step 3: LLM model ping --- | ||||||||||||||||||
| llm_enabled = get_env_bool("ENABLE_LLM_ENRICHMENT", False) or get_env_bool("ENABLE_LLM_AUTH_EXTRACTION", False) | ||||||||||||||||||
|
|
||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log message states that the index will be built 'on first request', but according to the
lifespanimplementation inserver.pyand the comments added in this PR (lines 67-68), the warmup task is triggered eagerly at startup in the background. This discrepancy can be confusing for operators monitoring the server's initialization.