Skip to content

test: token balances across multiple participant nodes#197

Merged
salindne merged 3 commits intomainfrom
test/multi-participant-node
Apr 13, 2026
Merged

test: token balances across multiple participant nodes#197
salindne merged 3 commits intomainfrom
test/multi-participant-node

Conversation

@dhyaniarun1993
Copy link
Copy Markdown
Member

No description provided.

@dhyaniarun1993 dhyaniarun1993 self-assigned this Apr 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test script, test-cip56-multi-participant.go, designed to validate CIP56 token balances across multiple Canton participants and issuers using external parties. The script automates synchronizer detection, party allocation, token configuration, and cross-participant balance verification. Review feedback identified significant issues with numeric handling, specifically pointing out that string-based trimming and float64 arithmetic are unsuitable for precise token balances; the use of math/big.Rat was recommended for all amount comparisons and summations. Additionally, suggestions were made to improve error handling during DAR file discovery and to clean up unused variables in the file-walking logic.

Comment thread scripts/testing/test-cip56-multi-participant.go Outdated
Comment thread scripts/testing/test-cip56-multi-participant.go Outdated
Comment thread scripts/testing/test-cip56-multi-participant.go
Comment thread scripts/testing/test-cip56-multi-participant.go Outdated
@salindne salindne merged commit 23f80c9 into main Apr 13, 2026
2 checks passed
@salindne salindne deleted the test/multi-participant-node branch April 13, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants