Skip to content

Normalize remaining non-Common RPC param names to camelCase in OpenRPC#7190

Merged
sudo-shashank merged 2 commits into
mainfrom
copilot/change-existing-rpc-params-names
Jun 18, 2026
Merged

Normalize remaining non-Common RPC param names to camelCase in OpenRPC#7190
sudo-shashank merged 2 commits into
mainfrom
copilot/change-existing-rpc-params-names

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR completes the remaining RPC parameter naming cleanup by converting non-camelCase parameter names in non-Common methods to camelCase, with emphasis on non-Common namespaces (including F3 and related endpoints). It also aligns generated OpenRPC output with the updated names.

  • Scope: remaining non-camelCase PARAM_NAMES

    • Updated snake_case parameter names to camelCase across:
      • auth, wallet, chain, msig, state, net, f3
    • Kept naming semantic, and expanded abbreviated names where it improved clarity:
      • start_tskstartTipsetKey
      • end_tskendTipsetKey
  • OpenRPC schema alignment

    • Regenerated snapshots impacted by param-name metadata changes:
      • src/rpc/snapshots/forest__rpc__tests__rpc__v0.snap
      • src/rpc/snapshots/forest__rpc__tests__rpc__v1.snap
  • Representative change

    // before
    const PARAM_NAMES: [&'static str; 3] = ["address", "start_tsk", "end_tsk"];
    
    // after
    const PARAM_NAMES: [&'static str; 3] = ["address", "startTipsetKey", "endTipsetKey"];

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Change existing RPC params' names to camelCase Normalize remaining non-Common RPC param names to camelCase in OpenRPC Jun 18, 2026
Copilot AI requested a review from LesnyRumcajs June 18, 2026 10:53
@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Jun 18, 2026
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review June 18, 2026 11:02
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner June 18, 2026 11:02
@LesnyRumcajs LesnyRumcajs requested review from sudo-shashank and removed request for a team June 18, 2026 11:02
@LesnyRumcajs

Copy link
Copy Markdown
Member

@copilot sign the CLA

@sudo-shashank sudo-shashank added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit f574cdf Jun 18, 2026
40 of 62 checks passed
@sudo-shashank sudo-shashank deleted the copilot/change-existing-rpc-params-names branch June 18, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants