fix: review requests

Author: brech1

packages/beacon-node/test/spec/downloadTests.ts

@@ -4,14 +4,10 @@ import {downloadNightlyTests} from "@lodestar/spec-test-util/downloadNightlyTest
 import {downloadTests} from "@lodestar/spec-test-util/downloadTests";
 import {blsSpecTests, ethereumConsensusSpecsTests} from "./specTestVersioning.js";
 
-const onError = (e: Error): void => {
-  console.error(e);
-  process.exit(1);
-};
-
-const [nightlyArg, repo, branch] = process.argv.slice(2);
+const [date, repo, branch] = process.argv.slice(2);
+const downloads = [downloadTests(blsSpecTests, console.log)];
 
-if (nightlyArg) {
+if (date) {
   config({path: path.join(import.meta.dirname, "../../../../.env")});
 
   const opts = {
@@ -20,10 +16,12 @@ if (nightlyArg) {
     ...(branch && {branch}),
   };
 
-  downloadTests(blsSpecTests, console.log).catch(onError);
-  downloadNightlyTests(opts, console.log, nightlyArg).catch(onError);
+  downloads.push(downloadNightlyTests(opts, console.log, date));
 } else {
-  for (const opts of [ethereumConsensusSpecsTests, blsSpecTests]) {
-    downloadTests(opts, console.log).catch(onError);
-  }
+  downloads.push(downloadTests(ethereumConsensusSpecsTests, console.log));
 }
+
+await Promise.all(downloads).catch((e: Error) => {
+  console.error(e);
+  process.exit(1);
+});

packages/spec-test-util/src/downloadNightlyTests.ts

@@ -20,9 +20,12 @@ async function ghApiFetch<T>(endpoint: string, token: string): Promise<T> {
 }
 
 async function resolveNightlyRunId(repo: string, token: string, date?: string, branch?: string): Promise<number> {
-  const query = "status=success&per_page=1" + (branch ? `&branch=${branch}` : "") + (date ? `&created=${date}` : "");
-  const {workflow_runs} = await ghApiFetch<WorkflowRunsResponse>(
-    `/repos/${repo}/actions/workflows/tests.yml/runs?${query}`,
+  const params = new URLSearchParams({status: "success", per_page: "1"});
+  if (branch) params.append("branch", branch);
+  if (date) params.append("created", date);
+
+  const { workflow_runs } = await ghApiFetch<WorkflowRunsResponse>(
+    `/repos/${repo}/actions/workflows/tests.yml/runs?${params}`,
     token
   );
 
@@ -50,10 +53,7 @@ export async function downloadNightlyTests(
   const runId = await resolveNightlyRunId(repo, token, resolvedDate, opts.branch);
   log(`Resolved nightly${resolvedDate ? ` ${resolvedDate}` : ""} to run ${runId}`);
 
-  const {artifacts} = await ghApiFetch<ArtifactsListResponse>(
-    `/repos/${repo}/actions/runs/${runId}/artifacts`,
-    token
-  );
+  const {artifacts} = await ghApiFetch<ArtifactsListResponse>(`/repos/${repo}/actions/runs/${runId}/artifacts`, token);
 
   const urlByTest: Record<string, string> = {};
   const available: string[] = [];