feat: send validator registrations to builder using ssz#7444
Conversation
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7444 +/- ##
============================================
+ Coverage 56.08% 56.09% +0.01%
============================================
Files 823 823
Lines 58031 58044 +13
Branches 4463 4463
============================================
+ Hits 32545 32561 +16
+ Misses 25419 25416 -3
Partials 67 67 🚀 New features to boost your workflow:
|
| }, | ||
| resp: EmptyResponseCodec, | ||
| init: { | ||
| requestWireFormat: WireFormat.ssz, |
There was a problem hiding this comment.
part of spec now ethereum/beacon-APIs#508, we can enable SSZ by default, worst case we get a 415 response from beacon node and fall back to JSON
I guess we're assuming that all mev sidecars support the latest beacon API as of electra release? |
still cautions with merging this one, the builder spec has ssz support for the api but the problem is that mev-boost just passes those requests through to relay, so it's actually the relay that needs to support ssz or respond with 415, I haven't validated this yet on any public network, and there was also a bug in some relays.. imo should hold off merging this for a bit, marked it as ready for review as PR itself is ready |
|
no issues running this branch on hoodi, relays support ssz validator registrations there |
|
🎉 This PR is included in v1.30.0 🎉 |
Motivation
See ethereum/builder-specs#110
Description
Send validator registrations to builder using SSZ
TODO
forward bytes submitted through registerValidator beacon api to skip extra serialization stepcannot be done right now since we are filtering registrations here so forwarding raw SSZ bytes is not an option and extra work is likely not worth it as serialization is cheap anyways when using SSZCloses #7369