-
-
Notifications
You must be signed in to change notification settings - Fork 455
feat: unknown payload sync for incoming blocks #9102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
677f8a3
init
ensi321 2e20f2b
typo
ensi321 ed1c68f
Add getSerializedExecutionPayloadEnvelope
ensi321 ba70076
Apply suggestion from @gemini-code-assist[bot]
ensi321 9f82f73
update todo
ensi321 7b5f809
remove slot param
ensi321 8ab9114
Merge branch 'unstable' into nc/epbs-reqresp
ensi321 6835906
Merge branch 'unstable' into nc/epbs-reqresp
ensi321 95f7a9b
Merge branch 'unstable' into nc/epbs-reqresp
ensi321 3f3409e
Merge branch 'unstable' into nc/epbs-reqresp
ensi321 583a07b
fix: resolve TODOs in getSerializedExecutionPayloadEnvelope
ensi321 d65eac2
Merge branch 'unstable' into nc/epbs-reqresp
ensi321 88dd816
feat: add client-side reqresp methods for execution payload envelopes
ensi321 968e53f
init
ensi321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metric
lodestar_sync_block_input_payload_fetch_success_totalis defined as agauge, but it's used as a counter since its value only ever increases. For metrics that represent a cumulative count, it's more idiomatic and correct to use acounter. This provides clearer intent and allows monitoring systems like Prometheus to apply counter-specific functions (e.g.,rate()).This feedback also applies to other new metrics in this file that are used as counters but defined as gauges, such as
payloadFetchError,payloadRequests, and the metrics withinawaitingEnvelopeGossipMessages.