fix: revert anchor block PTC vote override#9264
Merged
nflaig merged 1 commit intoChainSafe:unstablefrom Apr 23, 2026
Merged
Conversation
Revert the anchor-block PTC vote all-true override added in ChainSafe#9188. Upstream `consensus-specs` `master` fixed the underlying spec bug in: - c7a0a8527 — "Remove incorrect anchor seed for payload votes (ChainSafe#5135)" `specs/gloas/fork-choice.md#get_forkchoice_store` on `master` now initializes: payload_timeliness_vote={} payload_data_availability_vote={} per https://github.com/ethereum/consensus-specs/blob/master/specs/gloas/fork-choice.md#modified-get_forkchoice_store So Lodestar should stop force-seeding the anchor block's PTC votes to all-true in `ProtoArray.initialize()` and return anchor initialization to the default `onBlock()` behavior. Note: `v1.7.0-alpha.5` (the current spec-test target) still carries the old anchor all-true seed, because ChainSafe#5135 landed on spec master after the alpha.5 cut. Aligning with master now means a future spec tag (alpha.6+) picking up ChainSafe#5135 will keep working; local spec test coverage for the anchor boundary may need adjustment until that tag lands and `spec-tests-version.json` is bumped. 🤖 Generated with AI assistance
nflaig
approved these changes
Apr 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9264 +/- ##
=========================================
Coverage 52.53% 52.53%
=========================================
Files 848 848
Lines 61311 61311
Branches 4510 4510
=========================================
Hits 32207 32207
Misses 29039 29039
Partials 65 65 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert the anchor-block PTC vote all-true override added in #9188.
Upstream
consensus-specsmasterfixed the underlying spec bug in:c7a0a8527— Remove incorrect anchor seed for payload votes (Release v1.4.3 #5135)specs/gloas/fork-choice.md#get_forkchoice_storeonmasternow initializes:So Lodestar should stop force-seeding the anchor block's PTC votes to all-true in
ProtoArray.initialize()— anchor initialization returns to the defaultonBlock()behavior.This PR removes the temporary 8-line override.
Tag vs. master
`v1.7.0-alpha.5` (current spec-test target) still carries the old anchor all-true seed — #5135 landed on spec master after the alpha.5 cut. Aligning Lodestar with
masternow means:spec-tests-version.jsonbumps to that next tagPer direction from @nflaig to follow latest
masterof the spec.Context
get_forkchoice_storebug is fixed #9239.AI assistance
Drafted and validated with AI assistance.