chore: add workflow to run nightly spec tests#9268
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation for downloading nightly spec test artifacts and updates the logic for resolving nightly run IDs to prioritize scheduled runs unless a specific branch is targeted. Review feedback indicates that the documentation examples in AGENTS.md are inconsistent with the current CLI implementation regarding argument count, order, and URL format. Additionally, there is a suggestion to allow non-scheduled events when a specific date is provided to ensure manual re-runs can be retrieved.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
When the user passes a specific date, don't also force event=schedule — a scheduled run that failed but was manually re-run should still be findable. event=schedule still applies to the default no-args path so PR runs can't outrank the latest master nightly in CI. Addresses gemini-code-assist review on #9268.
twoeths
approved these changes
Apr 24, 2026
spiral-ladder
approved these changes
Apr 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9268 +/- ##
=========================================
Coverage 52.52% 52.52%
=========================================
Files 848 848
Lines 61304 61304
Branches 4510 4510
=========================================
Hits 32201 32201
Misses 29038 29038
Partials 65 65 🚀 New features to boost your workflow:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #9221 which adds a worfklow to run nightly spec tests