test: fix unknownBlockSync e2e assertions for gloas#9276
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the unknownBlockSync E2E tests by removing the maybeWaitForPayloadImported logic and instead retrieving PayloadEnvelopeInput directly from the cache during the incompletePayloadEnvelope test case. Feedback indicates that removing the wait for the payload sync to complete may introduce flakiness, as the test could finish and shut down the node before the background sync process actually finishes.
Comment on lines
+238
to
+241
| const payloadInput = bn2.chain.seenPayloadEnvelopeInputCache.get(headRootHex); | ||
| if (!payloadInput) { | ||
| throw Error(`Expected PayloadEnvelopeInput for ${headRootHex} after block sync`); | ||
| } |
Contributor
There was a problem hiding this comment.
The incompletePayloadEnvelope test case triggers a payload sync by emitting an event but does not wait for the sync to complete. Since the sync happens in the background, the test might finish and close the node (via afterEach) before the payload is actually imported. This could lead to flakiness or a false positive where the sync logic is triggered but not actually completed. Consider waiting for the routes.events.EventType.executionPayload event after emitting the trigger to ensure the sync is fully exercised.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
commented
Apr 25, 2026
| } | ||
|
|
||
| // only await payload import for events that imply importing it | ||
| await maybeWaitForPayloadImported; |
Member
Author
There was a problem hiding this comment.
hmm might be that the test is just not waiting now? tests are passing but mayeb we a not asserting stuff anymore
Contributor
There was a problem hiding this comment.
| Case | Drives head-payload import? | Currently asserted? |
|---|---|---|
| blockUnknownParent | no — only parent payloads | head event only — correct |
| unknownBlockRoot | no — only parent payloads | head event only — correct |
| incompleteBlockInput | no — only parent payloads | head event only — correct |
| unknownEnvelopeBlockRoot | yes | head event only — gap |
| envelopeUnknownBlock (new) | yes | head + payload — fixed |
| incompletePayloadEnvelope | yes | head + payload — fixed |
we are only missing unknownEnvelopeBlockRoot, gonna add that
wemeetagain
approved these changes
Apr 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9276 +/- ##
=========================================
Coverage 52.58% 52.58%
=========================================
Files 848 848
Lines 61136 61136
Branches 4505 4505
=========================================
Hits 32147 32147
Misses 28925 28925
Partials 64 64 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We merged #9241 without actually checking if e2e test passed.