Sync main for review/audit#29
Open
rob1997 wants to merge 80 commits into
Open
Conversation
* Asset Smart Contract - first draft * Switched to permit flow instead of approval flow * Added scripts, tests and fixes and requested changes
* Asset Smart Contract - first draft * Switched to permit flow instead of approval flow * Added scripts, tests and fixes and requested changes * AssetRegistry.sol initial draft * Asset Registry tests * AssetRegistry scripts * removed revoke and remove from Registry added access controls for viewing someone elses subscription
* run script implemented * Added Run CI * utils added
* checkpoint * Fee split implemented * test trial * Fee Split Registry Test * splitter tests refactored * some sensible renames * fixed a subscription bug * refactored scripts
* Asset contract documented * AssetRegistry Documented * Scripts Documented * Added set subscription price function * Added RPC API ref * Added Installation and RPC API Reference to readme.md * New Events and event params * Compile error fix * empty commit
- Updated createAsset script function to allow for external users.
viatrix
requested changes
Feb 20, 2026
…e returns expiry (#32) * Changelog - BetterDeployments - Scripts improved - Additional RPC APIs for Asset and Asset Registiries * Changelog - Sepolia Base deployments added - new deployments for sepolia - removed all CI/CD except for tests - subscribe now returns the expiry * Updated readme based on changes * Added return values * Removed old script usages * Updated script documentations
* Added Tests * Added event emit tests * Missing tests added
* Typo fix * Unity write-up
This was referenced Feb 25, 2026
* requested changes made * RPC API Refs update * Cancellation implemented * Fixed fee share test and claim functions * added some new tests * revoke subscription tests added * cancel subscription tests added * renamed some methods and added claimRegistryFee tests * optmized/simplified existing tests * added some missing tests * updated RPC API refs in README.md and updated an inconsistent return value * readme updated * Readme edits * new deployments
…x, tests (#45) * viewSubscription -> isSubscriptionActive * Updated registry fee share bug fixed * Added tests for fix and ZeroTotalFeeShare error revert * zero total fee share tests * Switched to SafeErc20 * updated tests * updated docs
Bumps [hono](https://github.com/honojs/hono) from 4.12.7 to 4.12.14. - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v4.12.7...v4.12.14) --- updated-dependencies: - dependency-name: hono dependency-version: 4.12.14 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
* git ignore * working build * submodules * submodules updated * forge fmt * updated scripts directory * documentation updated * moved deployments
* event updated * tests fixed * updated events doc * forge fmt
* checkpoint * new cancel flow * checkpoint * fixed some warnings * Better events * tests and docs updated * forge fmt * modified subscription cancelled and revoked events and added new subscription removed event * Tests fixed, new tests added and docs updated * minor rename
* Add fixed subscription duration * Update formatting * Updates after review * Remove cancelled flag * Add endTime to events * Update tests * Small optimizations * doc/comment edits * test_claimCreatorFee_incrementalMultiPeriodSingleNonce test_claimRegistryFee_incrementalMultiPeriodSingleNonce * docs, scripts update and forge fmt --------- Co-authored-by: rob1997 <robelgetnetrg@gmail.com>
* Claimed events now have claimed at timestamp and nonce parameters * forge fmt
* Mnemonic setup * docs * first draft for deployments.yml * deployments.yml:test_0 * deployments.yml:test_1 * deployments.yml:test_2 * deployments.yml:test_3 * deployments.yml:test_4 * release script and revert testing triggers, also edits on seed script * docs
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
…ee share (#135) * Avoid floating point precision issues when calculating the registry fee share * tests and docs
Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
- Asset #4 added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
maininto this branch for review and audit.Related: #25
Made with Cursor