|
| 1 | +package jovian |
| 2 | + |
| 3 | +import ( |
| 4 | + "math/big" |
| 5 | + "testing" |
| 6 | + |
| 7 | + "github.com/ethereum-optimism/optimism/op-devstack/devtest" |
| 8 | + "github.com/ethereum-optimism/optimism/op-devstack/dsl" |
| 9 | + "github.com/ethereum-optimism/optimism/op-devstack/presets" |
| 10 | + "github.com/ethereum-optimism/optimism/op-node/rollup" |
| 11 | + "github.com/ethereum-optimism/optimism/op-service/eth" |
| 12 | + |
| 13 | + "encoding/binary" |
| 14 | + "time" |
| 15 | + |
| 16 | + "github.com/ethereum-optimism/optimism/op-chain-ops/devkeys" |
| 17 | + "github.com/ethereum-optimism/optimism/op-service/txintent/bindings" |
| 18 | + "github.com/ethereum-optimism/optimism/op-service/txintent/contractio" |
| 19 | + "github.com/ethereum/go-ethereum/consensus/misc/eip1559" |
| 20 | + "github.com/ethereum/go-ethereum/core/types" |
| 21 | + "github.com/ethereum/go-ethereum/rlp" |
| 22 | +) |
| 23 | + |
| 24 | +type minBaseFeeEnv struct { |
| 25 | + l1Client *dsl.L1ELNode |
| 26 | + l2Network *dsl.L2Network |
| 27 | + l2EL *dsl.L2ELNode |
| 28 | + systemConfig minBaseFeeSystemConfig |
| 29 | +} |
| 30 | + |
| 31 | +type minBaseFeeSystemConfig struct { |
| 32 | + SetMinBaseFee func(minBaseFee uint64) bindings.TypedCall[any] `sol:"setMinBaseFee"` |
| 33 | + MinBaseFee func() bindings.TypedCall[uint64] `sol:"minBaseFee"` |
| 34 | +} |
| 35 | + |
| 36 | +func newMinBaseFee(t devtest.T, l2Network *dsl.L2Network, l1EL *dsl.L1ELNode, l2EL *dsl.L2ELNode) *minBaseFeeEnv { |
| 37 | + systemConfig := bindings.NewBindings[minBaseFeeSystemConfig]( |
| 38 | + bindings.WithClient(l1EL.EthClient()), |
| 39 | + bindings.WithTo(l2Network.Escape().Deployment().SystemConfigProxyAddr()), |
| 40 | + bindings.WithTest(t)) |
| 41 | + |
| 42 | + return &minBaseFeeEnv{ |
| 43 | + l1Client: l1EL, |
| 44 | + l2Network: l2Network, |
| 45 | + l2EL: l2EL, |
| 46 | + systemConfig: systemConfig, |
| 47 | + } |
| 48 | +} |
| 49 | + |
| 50 | +func (mbf *minBaseFeeEnv) checkCompatibility(t devtest.T) { |
| 51 | + _, err := contractio.Read(mbf.systemConfig.MinBaseFee(), t.Ctx()) |
| 52 | + if err != nil { |
| 53 | + t.Fail() |
| 54 | + } |
| 55 | +} |
| 56 | + |
| 57 | +func (mbf *minBaseFeeEnv) getSystemConfigOwner(t devtest.T) *dsl.EOA { |
| 58 | + priv := mbf.l2Network.Escape().Keys().Secret(devkeys.SystemConfigOwner.Key(mbf.l2Network.ChainID().ToBig())) |
| 59 | + return dsl.NewKey(t, priv).User(mbf.l1Client) |
| 60 | +} |
| 61 | + |
| 62 | +func (mbf *minBaseFeeEnv) setMinBaseFeeViaSytemConfigOnL1(t devtest.T, minBaseFee uint64) { |
| 63 | + owner := mbf.getSystemConfigOwner(t) |
| 64 | + |
| 65 | + _, err := contractio.Write(mbf.systemConfig.SetMinBaseFee(minBaseFee), t.Ctx(), owner.Plan()) |
| 66 | + t.Require().NoError(err, "SetMinBaseFee transaction failed") |
| 67 | + |
| 68 | + t.Logf("Set min base fee on L1: minBaseFee=%d", minBaseFee) |
| 69 | +} |
| 70 | + |
| 71 | +func (mbf *minBaseFeeEnv) verifyMinBaseFee(t devtest.T, minBase *big.Int) { |
| 72 | + // Wait for the next block |
| 73 | + _ = mbf.l2EL.WaitForBlock() |
| 74 | + el := mbf.l2EL.Escape().EthClient() |
| 75 | + info, err := el.InfoByLabel(t.Ctx(), "latest") |
| 76 | + t.Require().NoError(err) |
| 77 | + |
| 78 | + // Verify base fee is clamped |
| 79 | + t.Require().True(info.BaseFee().Cmp(minBase) >= 0, "expected base fee to be >= minBaseFee") |
| 80 | + t.Logf("base fee %s, minBase %s", info.BaseFee(), minBase) |
| 81 | +} |
| 82 | + |
| 83 | +// waitForMinBaseFeeConfigChangeOnL2 waits until the L2 latest payload extra-data encodes the expected min base fee. |
| 84 | +func (mbf *minBaseFeeEnv) waitForMinBaseFeeConfigChangeOnL2(t devtest.T, expected uint64) { |
| 85 | + client := mbf.l2EL.Escape().L2EthClient() |
| 86 | + expectedExtraData := eth.BytesMax32(eip1559.EncodeJovianExtraData(250, 6, expected)) |
| 87 | + |
| 88 | + // Check extradata in block header (for all clients) |
| 89 | + var actualBlockExtraData []byte |
| 90 | + t.Require().Eventually(func() bool { |
| 91 | + info, err := client.InfoByLabel(t.Ctx(), "latest") |
| 92 | + if err != nil { |
| 93 | + return false |
| 94 | + } |
| 95 | + |
| 96 | + // Get header RLP and decode to access Extra field |
| 97 | + headerRLP, err := info.HeaderRLP() |
| 98 | + if err != nil { |
| 99 | + return false |
| 100 | + } |
| 101 | + |
| 102 | + var header types.Header |
| 103 | + if err := rlp.DecodeBytes(headerRLP, &header); err != nil { |
| 104 | + return false |
| 105 | + } |
| 106 | + |
| 107 | + if len(header.Extra) != 17 { |
| 108 | + return false |
| 109 | + } |
| 110 | + |
| 111 | + got := binary.BigEndian.Uint64(header.Extra[9:]) |
| 112 | + actualBlockExtraData = header.Extra |
| 113 | + return got == expected |
| 114 | + }, 2*time.Minute, 5*time.Second, "L2 min base fee in block header did not sync within timeout") |
| 115 | + |
| 116 | + t.Require().Equal(expectedExtraData, eth.BytesMax32(actualBlockExtraData), "block header extradata doesnt match") |
| 117 | +} |
| 118 | + |
| 119 | +// TestMinBaseFee verifies configurable minimum base fee using devstack presets. |
| 120 | +func TestMinBaseFee(gt *testing.T) { |
| 121 | + t := devtest.SerialT(gt) |
| 122 | + sys := presets.NewMinimal(t) |
| 123 | + require := t.Require() |
| 124 | + |
| 125 | + err := dsl.RequiresL2Fork(t.Ctx(), sys, 0, rollup.Jovian) |
| 126 | + require.NoError(err, "Jovian fork must be active for this test") |
| 127 | + |
| 128 | + minBaseFee := newMinBaseFee(t, sys.L2Chain, sys.L1EL, sys.L2EL) |
| 129 | + minBaseFee.checkCompatibility(t) |
| 130 | + |
| 131 | + systemOwner := minBaseFee.getSystemConfigOwner(t) |
| 132 | + sys.FunderL1.FundAtLeast(systemOwner, eth.OneTenthEther) |
| 133 | + |
| 134 | + testCases := []struct { |
| 135 | + name string |
| 136 | + minBaseFee uint64 |
| 137 | + }{ |
| 138 | + // High minimum base fee |
| 139 | + {"MinBaseFeeHigh", 2_000_000_000}, |
| 140 | + // Medium minimum base fee |
| 141 | + {"MinBaseFeeMedium", 1_000_000_000}, |
| 142 | + // Zero minimum base fee (not enforced) |
| 143 | + {"MinBaseFeeZero", 0}, |
| 144 | + } |
| 145 | + |
| 146 | + for _, tc := range testCases { |
| 147 | + t.Run(tc.name, func(t devtest.T) { |
| 148 | + minBaseFee.setMinBaseFeeViaSytemConfigOnL1(t, tc.minBaseFee) |
| 149 | + minBaseFee.waitForMinBaseFeeConfigChangeOnL2(t, tc.minBaseFee) |
| 150 | + |
| 151 | + minBaseFee.verifyMinBaseFee(t, big.NewInt(int64(tc.minBaseFee))) |
| 152 | + |
| 153 | + t.Log("Test completed successfully:", |
| 154 | + "testCase", tc.name, |
| 155 | + "minBaseFee", tc.minBaseFee) |
| 156 | + }) |
| 157 | + } |
| 158 | +} |
0 commit comments