Skip to content

Commit b96b7e2

Browse files
committed
Lint Fixes
1 parent 7f8b289 commit b96b7e2

3 files changed

Lines changed: 44 additions & 83 deletions

File tree

src/ChainSafe.Gaming.Lootboxes.Chainlink/LootboxService.cs

Lines changed: 17 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using ChainSafe.Gaming.Evm.Signers;
1010
using ChainSafe.Gaming.Evm.Transactions;
1111
using ChainSafe.Gaming.Web3;
12-
1312
using ChainSafe.Gaming.Web3.Core;
1413
using ChainSafe.Gaming.Web3.Core.Debug;
1514
using ChainSafe.Gaming.Web3.Environment;
@@ -32,22 +31,15 @@ public class LootboxService : ILootboxService, ILifecycleParticipant
3231
private Contract contract;
3332
private Dictionary<string, RewardType> rewardTypeByTokenAddress;
3433

35-
public LootboxService(
36-
LootboxServiceConfig config,
37-
IContractBuilder contractBuilder,
38-
IRpcProvider rpcProvider)
34+
public LootboxService(LootboxServiceConfig config, IContractBuilder contractBuilder, IRpcProvider rpcProvider)
3935
{
4036
this.rpcProvider = rpcProvider;
4137
this.config = config;
4238
this.contractBuilder = contractBuilder;
4339
}
4440

45-
public LootboxService(
46-
LootboxServiceConfig config,
47-
IContractBuilder contractBuilder,
48-
IRpcProvider rpcProvider,
49-
ISigner signer)
50-
: this(config, contractBuilder, rpcProvider)
41+
public LootboxService(LootboxServiceConfig config, IContractBuilder contractBuilder, IRpcProvider rpcProvider,
42+
ISigner signer) : this(config, contractBuilder, rpcProvider)
5143
{
5244
this.signer = signer;
5345
}
@@ -92,8 +84,7 @@ public async Task<List<uint>> GetLootboxTypes()
9284

9385
if (bigIntTypes.Any(v => v > int.MaxValue))
9486
{
95-
throw new Web3Exception(
96-
"Internal Error. Lootbox type is greater than int.MaxValue.");
87+
throw new Web3Exception("Internal Error. Lootbox type is greater than int.MaxValue.");
9788
}
9889

9990
var types = bigIntTypes.Select(bigInt => (uint)bigInt).ToList();
@@ -110,15 +101,12 @@ public async Task<uint> BalanceOf(uint lootboxType)
110101

111102
public async Task<uint> BalanceOf(string account, uint lootboxType)
112103
{
113-
var response = await this.contract.Call(
114-
"balanceOf",
115-
new object[] { account, lootboxType });
104+
var response = await this.contract.Call("balanceOf", new object[] { account, lootboxType });
116105
var bigIntBalance = (BigInteger)response[0];
117106

118107
if (bigIntBalance > int.MaxValue)
119108
{
120-
throw new Web3Exception(
121-
"Internal Error. Balance is greater than int.MaxValue.");
109+
throw new Web3Exception("Internal Error. Balance is greater than int.MaxValue.");
122110
}
123111

124112
var balance = (uint)bigIntBalance;
@@ -132,8 +120,7 @@ public async Task<BigInteger> CalculateOpenPrice(uint lootboxType, uint lootboxC
132120
var rawGasPrice = (await this.rpcProvider.GetGasPrice()).AssertNotNull("gasPrice").Value;
133121
var safeGasPrice = (rawGasPrice * 2) + BigInteger.Divide(rawGasPrice, new BigInteger(2)); // 300%
134122

135-
var response = await this.contract.Call(
136-
"calculateOpenPrice",
123+
var response = await this.contract.Call("calculateOpenPrice",
137124
new object[] { 50000 + (GasPerUnit * rewardCount), safeGasPrice, rewardCount, });
138125
var openPrice = (BigInteger)response[0];
139126

@@ -153,17 +140,17 @@ public async Task<uint> OpeningLootboxType()
153140
var playerAddress = this.GetCurrentPlayerAddress();
154141

155142
// This response is actually very different from all the others since it returns several components
156-
var response = (List<ParameterOutput>)(await this.contract.Call("getOpenerRequestDetails", new object[] { playerAddress }))[0];
143+
var response =
144+
(List<ParameterOutput>)(await this.contract.Call("getOpenerRequestDetails",
145+
new object[] { playerAddress }))[0];
157146
var address = (string)response[0].Result;
158147
var unitsToGet = (BigInteger)response[1].Result;
159148
var lootboxType = ((List<BigInteger>)response[2].Result)[0];
160149
if (!string.IsNullOrEmpty(address) && unitsToGet == 0)
161150
{
162151
// we can early return here, but, it's not necessary since unitstoget will be 0 regardless and this
163152
// call will fulfill every request that's been missing.
164-
await this.contract.Send(
165-
"recoverBoxes",
166-
new object[] { playerAddress });
153+
await this.contract.Send("recoverBoxes", new object[] { playerAddress });
167154
}
168155

169156
if (unitsToGet > uint.MaxValue)
@@ -179,8 +166,7 @@ public async Task OpenLootbox(uint lootboxType, uint lootboxCount = 1)
179166
var rewardCount = lootboxType * lootboxCount;
180167
var openPrice = await this.CalculateOpenPrice(lootboxCount, lootboxCount);
181168

182-
await this.contract.Send(
183-
"open",
169+
await this.contract.Send("open",
184170
new object[] { 50000 + (GasPerUnit * rewardCount), new[] { lootboxType }, new[] { lootboxCount } },
185171
new TransactionRequest { Value = new HexBigInteger(openPrice) });
186172
}
@@ -194,9 +180,7 @@ public async Task<bool> CanClaimRewards()
194180

195181
public async Task<bool> CanClaimRewards(string account)
196182
{
197-
var response = await this.contract.Call(
198-
"canClaimRewards",
199-
new object[] { account });
183+
var response = await this.contract.Call("canClaimRewards", new object[] { account });
200184
var canClaimRewards = (bool)response[0];
201185

202186
return canClaimRewards;
@@ -214,9 +198,7 @@ public async Task<LootboxRewards> ClaimRewards(string account)
214198
var (_, receipt) = await this.contract.SendWithReceipt("claimRewards", new object[] { account });
215199
var logs = receipt.Logs.Select(jToken => JsonConvert.DeserializeObject<FilterLog>(jToken.ToString()));
216200
var eventAbi = EventExtensions.GetEventABI<RewardsClaimedEvent>();
217-
var eventLogs = logs
218-
.Select(log => eventAbi.DecodeEvent<RewardsClaimedEvent>(log))
219-
.Where(l => l != null);
201+
var eventLogs = logs.Select(log => eventAbi.DecodeEvent<RewardsClaimedEvent>(log)).Where(l => l != null);
220202

221203
if (!eventLogs.Any())
222204
{
@@ -239,15 +221,13 @@ LootboxRewards ExtractRewards(IEnumerable<EventLog<RewardsClaimedEvent>> eventLo
239221
case RewardType.Erc20:
240222
rewards.Erc20Rewards.Add(new Erc20Reward
241223
{
242-
ContractAddress = eventData.TokenAddress,
243-
AmountRaw = eventData.Amount,
224+
ContractAddress = eventData.TokenAddress, AmountRaw = eventData.Amount,
244225
});
245226
break;
246227
case RewardType.Erc721:
247228
rewards.Erc721Rewards.Add(new Erc721Reward
248229
{
249-
ContractAddress = eventData.TokenAddress,
250-
TokenId = eventData.TokenId,
230+
ContractAddress = eventData.TokenAddress, TokenId = eventData.TokenId,
251231
});
252232
break;
253233
case RewardType.Erc1155:
@@ -261,8 +241,7 @@ LootboxRewards ExtractRewards(IEnumerable<EventLog<RewardsClaimedEvent>> eventLo
261241
case RewardType.Erc1155Nft:
262242
rewards.Erc1155NftRewards.Add(new Erc1155NftReward
263243
{
264-
ContractAddress = eventData.TokenAddress,
265-
TokenId = eventData.TokenId,
244+
ContractAddress = eventData.TokenAddress, TokenId = eventData.TokenId,
266245
});
267246
break;
268247
case RewardType.Unset:

src/ChainSafe.Gaming.Unity.MetaMask/MetaMaskProvider.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using System.Threading.Tasks;
22
using ChainSafe.Gaming.Evm;
33
using ChainSafe.Gaming.Web3;
4-
54
using ChainSafe.Gaming.Web3.Environment;
65
using ChainSafe.Gaming.Web3.Evm.Wallet;
76
using UnityEngine;
@@ -26,8 +25,8 @@ public class MetaMaskProvider : WalletProvider
2625
/// <param name="environment">Injected <see cref="Web3Environment"/>.</param>
2726
/// <param name="chainConfig">Injected <see cref="IChainConfig"/>.</param>
2827
/// <param name="chainRegistryProvider">Injected <see cref="ChainRegistryProvider"/>.</param>
29-
public MetaMaskProvider(Web3Environment environment, IChainConfig chainConfig, ChainRegistryProvider chainRegistryProvider)
30-
: base(environment, chainConfig)
28+
public MetaMaskProvider(Web3Environment environment, IChainConfig chainConfig,
29+
ChainRegistryProvider chainRegistryProvider) : base(environment, chainConfig)
3130
{
3231
logWriter = environment.LogWriter;
3332
this.chainConfig = chainConfig;
@@ -76,7 +75,6 @@ public override async Task<string> Connect()
7675
{
7776
logWriter.Log("Connecting from Metamask...");
7877

79-
8078
return await metaMaskController.Connect(chainConfig, chainRegistryProvider);
8179
}
8280
}

src/ChainSafe.Gaming.WalletConnect/WalletConnectProvider.cs

Lines changed: 25 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using ChainSafe.Gaming.WalletConnect.Storage;
1010
using ChainSafe.Gaming.WalletConnect.Wallets;
1111
using ChainSafe.Gaming.Web3;
12-
1312
using ChainSafe.Gaming.Web3.Core;
1413
using ChainSafe.Gaming.Web3.Core.Debug;
1514
using ChainSafe.Gaming.Web3.Environment;
@@ -55,14 +54,9 @@ public class WalletConnectProvider : WalletProvider, ILifecycleParticipant, ICon
5554
private bool initialized;
5655
private ConnectionHandlerConfig connectionHandlerConfig;
5756

58-
public WalletConnectProvider(
59-
IWalletConnectConfig config,
60-
DataStorage storage,
61-
IChainConfig chainConfig,
62-
IWalletRegistry walletRegistry,
63-
RedirectionHandler redirection,
64-
Web3Environment environment)
65-
: base(environment, chainConfig)
57+
public WalletConnectProvider(IWalletConnectConfig config, DataStorage storage, IChainConfig chainConfig,
58+
IWalletRegistry walletRegistry, RedirectionHandler redirection, Web3Environment environment) : base(
59+
environment, chainConfig)
6660
{
6761
this.redirection = redirection;
6862
this.walletRegistry = walletRegistry;
@@ -92,14 +86,11 @@ private async Task Initialize()
9286
return;
9387
}
9488

95-
9689
ValidateConfig();
9790

9891
WCLogger.Logger = new WCLogWriter(logWriter, config);
9992

100-
localData = !config.ForceNewSession
101-
? await storage.LoadLocalData() ?? new LocalData()
102-
: new LocalData();
93+
localData = !config.ForceNewSession ? await storage.LoadLocalData() ?? new LocalData() : new LocalData();
10394

10495
core = new WalletConnectCore(new CoreOptions
10596
{
@@ -132,13 +123,8 @@ private async Task Initialize()
132123
Events = new[] { "chainChanged", "accountsChanged" },
133124
Methods = new[]
134125
{
135-
"eth_sign",
136-
"personal_sign",
137-
"eth_signTypedData",
138-
"eth_signTransaction",
139-
"eth_sendTransaction",
140-
"eth_getTransactionByHash",
141-
"wallet_switchEthereumChain",
126+
"eth_sign", "personal_sign", "eth_signTypedData", "eth_signTransaction",
127+
"eth_sendTransaction", "eth_getTransactionByHash", "wallet_switchEthereumChain",
142128
"eth_blockNumber",
143129
},
144130
}
@@ -186,17 +172,16 @@ public override async Task<string> Connect()
186172
{
187173
var sessionStored = !string.IsNullOrEmpty(localData.SessionTopic);
188174

189-
session = !sessionStored
190-
? await ConnectSession()
191-
: await RestoreSession();
175+
session = !sessionStored ? await ConnectSession() : await RestoreSession();
192176

193177
localData.SessionTopic = session.Topic;
194178

195179
var sessionLocalWallet = GetSessionLocalWallet();
196180
if (sessionLocalWallet != null)
197181
{
198182
localData.ConnectedLocalWalletName = sessionLocalWallet.Name;
199-
WCLogger.Log($"\"{sessionLocalWallet.Name}\" set as locally connected wallet for the current session.");
183+
WCLogger.Log(
184+
$"\"{sessionLocalWallet.Name}\" set as locally connected wallet for the current session.");
200185
}
201186
else
202187
{
@@ -295,7 +280,8 @@ private async Task<SessionStruct> ConnectSession()
295280
{
296281
if (config.ConnectionHandlerProvider == null)
297282
{
298-
throw new WalletConnectException($"Can not connect to a new session. No {nameof(IConnectionHandlerProvider)} was set in config.");
283+
throw new WalletConnectException(
284+
$"Can not connect to a new session. No {nameof(IConnectionHandlerProvider)} was set in config.");
299285
}
300286

301287
var connectOptions = new ConnectOptions { RequiredNamespaces = requiredNamespaces };
@@ -310,16 +296,14 @@ private async Task<SessionStruct> ConnectSession()
310296
ConnectRemoteWalletUri = connectedData.Uri,
311297
DelegateLocalWalletSelectionToOs = OsManageWalletSelection,
312298
WalletLocationOption = config.WalletLocationOption,
313-
314299
LocalWalletOptions = !OsManageWalletSelection
315300
? walletRegistry.EnumerateSupportedWallets(osMediator.Platform)
316301
.ToList() // todo notify devs that some wallets don't work on Desktop
317302
: null,
318-
319-
RedirectToWallet = !OsManageWalletSelection
320-
? walletName => redirection.RedirectConnection(connectedData.Uri, walletName)
321-
: null,
322-
303+
RedirectToWallet =
304+
!OsManageWalletSelection
305+
? walletName => redirection.RedirectConnection(connectedData.Uri, walletName)
306+
: null,
323307
RedirectOsManaged = OsManageWalletSelection
324308
? () => redirection.RedirectConnectionOsManaged(connectedData.Uri)
325309
: null,
@@ -405,8 +389,7 @@ public override async Task<T> Request<T>(string method, params object[] paramete
405389

406390
var sessionTopic = session.Topic;
407391

408-
EventUtils.ListenOnce<PublishParams>(
409-
OnPublishedMessage,
392+
EventUtils.ListenOnce<PublishParams>(OnPublishedMessage,
410393
handler => core.Relayer.Publisher.OnPublishedMessage += handler,
411394
handler => core.Relayer.Publisher.OnPublishedMessage -= handler);
412395

@@ -434,17 +417,14 @@ private WalletModel GetSessionLocalWallet()
434417
{
435418
var nativeUrl = RemoveSlash(session.Peer.Metadata.Url);
436419

437-
var sessionWallet = walletRegistry
438-
.EnumerateSupportedWallets(osMediator.Platform)
420+
var sessionWallet = walletRegistry.EnumerateSupportedWallets(osMediator.Platform)
439421
.FirstOrDefault(w => RemoveSlash(w.Homepage) == nativeUrl);
440422

441423
return sessionWallet;
442424

443425
string RemoveSlash(string s)
444426
{
445-
return s.EndsWith('/')
446-
? s[..s.LastIndexOf('/')]
447-
: s;
427+
return s.EndsWith('/') ? s[..s.LastIndexOf('/')] : s;
448428
}
449429
}
450430

@@ -488,7 +468,8 @@ private string GetFullAddress()
488468
return defaultNamespace.Accounts[0];
489469
}
490470

491-
private async Task<T> WalletConnectRequest<T>(string topic, string method, string chainId, params object[] parameters)
471+
private async Task<T> WalletConnectRequest<T>(string topic, string method, string chainId,
472+
params object[] parameters)
492473
{
493474
// Helper method to make a request using WalletConnectSignClient.
494475
async Task<T> MakeRequest<TRequest>()
@@ -518,11 +499,14 @@ async Task<T> MakeRequest<TRequest>()
518499
// Using WalletConnect Blockchain API: https://docs.walletconnect.com/cloud/blockchain-api
519500
var url = $"https://rpc.walletconnect.com/v1?chainId={chain}&projectId={config.ProjectId}";
520501

521-
string body = JsonConvert.SerializeObject(new RpcRequestMessage(Guid.NewGuid().ToString(), method, parameters));
502+
string body =
503+
JsonConvert.SerializeObject(new RpcRequestMessage(Guid.NewGuid().ToString(), method,
504+
parameters));
522505

523506
var rawResult = await httpClient.PostRaw(url, body, "application/json");
524507

525-
RpcResponseMessage response = JsonConvert.DeserializeObject<RpcResponseMessage>(rawResult.Response);
508+
RpcResponseMessage response =
509+
JsonConvert.DeserializeObject<RpcResponseMessage>(rawResult.Response);
526510

527511
return response.Result.ToObject<T>();
528512
}

0 commit comments

Comments
 (0)