Skip to content

Commit 44ce6e7

Browse files
vaibhav9t1vaibhavw-techpvil02
authored
style: enable StaticVariableName in checkstyle (TheAlgorithms#5173)
* style: enable StaticVariableName in checkstyle * Refractored: enable StaticVariableName in checkstyle * style: mark more variables as `final` --------- Co-authored-by: vaibhav <vaibhav.waghmare@techprescient.com> Co-authored-by: vil02 <vil02@o2.pl>
1 parent 1607421 commit 44ce6e7

File tree

5 files changed

+47
-47
lines changed

5 files changed

+47
-47
lines changed

‎checkstyle.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
<!-- TODO <module name="MethodName"/> -->
116116
<module name="PackageName"/>
117117
<!-- TODO <module name="ParameterName"/> -->
118-
<!-- TODO <module name="StaticVariableName"/> -->
118+
<module name="StaticVariableName"/>
119119
<!-- TODO <module name="TypeName"/> -->
120120

121121
<!-- Checks for imports -->

‎src/main/java/com/thealgorithms/ciphers/DES.java‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
public class DES {
99

1010
private String key;
11-
private String[] subKeys;
11+
private final String[] subKeys;
1212

1313
private void sanitize(String key) {
1414
int length = key.length();
@@ -32,48 +32,48 @@ public void setKey(String key) {
3232
this.key = key;
3333
}
3434

35-
// Permutation table to convert initial 64 bit key to 56 bit key
36-
private static int[] PC1 = {57, 49, 41, 33, 25, 17, 9, 1, 58, 50, 42, 34, 26, 18, 10, 2, 59, 51, 43, 35, 27, 19, 11, 3, 60, 52, 44, 36, 63, 55, 47, 39, 31, 23, 15, 7, 62, 54, 46, 38, 30, 22, 14, 6, 61, 53, 45, 37, 29, 21, 13, 5, 28, 20, 12, 4};
35+
// Permutation table to convert initial 64-bit key to 56 bit key
36+
private static final int[] PC1 = {57, 49, 41, 33, 25, 17, 9, 1, 58, 50, 42, 34, 26, 18, 10, 2, 59, 51, 43, 35, 27, 19, 11, 3, 60, 52, 44, 36, 63, 55, 47, 39, 31, 23, 15, 7, 62, 54, 46, 38, 30, 22, 14, 6, 61, 53, 45, 37, 29, 21, 13, 5, 28, 20, 12, 4};
3737

3838
// Lookup table used to shift the initial key, in order to generate the subkeys
39-
private static int[] KEY_SHIFTS = {1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1};
39+
private static final int[] KEY_SHIFTS = {1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1};
4040

4141
// Table to convert the 56 bit subkeys to 48 bit subkeys
42-
private static int[] PC2 = {14, 17, 11, 24, 1, 5, 3, 28, 15, 6, 21, 10, 23, 19, 12, 4, 26, 8, 16, 7, 27, 20, 13, 2, 41, 52, 31, 37, 47, 55, 30, 40, 51, 45, 33, 48, 44, 49, 39, 56, 34, 53, 46, 42, 50, 36, 29, 32};
42+
private static final int[] PC2 = {14, 17, 11, 24, 1, 5, 3, 28, 15, 6, 21, 10, 23, 19, 12, 4, 26, 8, 16, 7, 27, 20, 13, 2, 41, 52, 31, 37, 47, 55, 30, 40, 51, 45, 33, 48, 44, 49, 39, 56, 34, 53, 46, 42, 50, 36, 29, 32};
4343

44-
// Initial permutatation of each 64 but message block
45-
private static int[] IP = {58, 50, 42, 34, 26, 18, 10, 2, 60, 52, 44, 36, 28, 20, 12, 4, 62, 54, 46, 38, 30, 22, 14, 6, 64, 56, 48, 40, 32, 24, 16, 8, 57, 49, 41, 33, 25, 17, 9, 1, 59, 51, 43, 35, 27, 19, 11, 3, 61, 53, 45, 37, 29, 21, 13, 5, 63, 55, 47, 39, 31, 23, 15, 7};
44+
// Initial permutation of each 64 but message block
45+
private static final int[] IP = {58, 50, 42, 34, 26, 18, 10, 2, 60, 52, 44, 36, 28, 20, 12, 4, 62, 54, 46, 38, 30, 22, 14, 6, 64, 56, 48, 40, 32, 24, 16, 8, 57, 49, 41, 33, 25, 17, 9, 1, 59, 51, 43, 35, 27, 19, 11, 3, 61, 53, 45, 37, 29, 21, 13, 5, 63, 55, 47, 39, 31, 23, 15, 7};
4646

4747
// Expansion table to convert right half of message blocks from 32 bits to 48 bits
48-
private static int[] expansion = {32, 1, 2, 3, 4, 5, 4, 5, 6, 7, 8, 9, 8, 9, 10, 11, 12, 13, 12, 13, 14, 15, 16, 17, 16, 17, 18, 19, 20, 21, 20, 21, 22, 23, 24, 25, 24, 25, 26, 27, 28, 29, 28, 29, 30, 31, 32, 1};
48+
private static final int[] EXPANSION = {32, 1, 2, 3, 4, 5, 4, 5, 6, 7, 8, 9, 8, 9, 10, 11, 12, 13, 12, 13, 14, 15, 16, 17, 16, 17, 18, 19, 20, 21, 20, 21, 22, 23, 24, 25, 24, 25, 26, 27, 28, 29, 28, 29, 30, 31, 32, 1};
4949

5050
// The eight substitution boxes are defined below
51-
private static int[][] s1 = {{14, 4, 13, 1, 2, 15, 11, 8, 3, 10, 6, 12, 5, 9, 0, 7}, {0, 15, 7, 4, 14, 2, 13, 1, 10, 6, 12, 11, 9, 5, 3, 8}, {4, 1, 14, 8, 13, 6, 2, 11, 15, 12, 9, 7, 3, 10, 5, 0}, {15, 12, 8, 2, 4, 9, 1, 7, 5, 11, 3, 14, 10, 0, 6, 13}};
51+
private static final int[][] S1 = {{14, 4, 13, 1, 2, 15, 11, 8, 3, 10, 6, 12, 5, 9, 0, 7}, {0, 15, 7, 4, 14, 2, 13, 1, 10, 6, 12, 11, 9, 5, 3, 8}, {4, 1, 14, 8, 13, 6, 2, 11, 15, 12, 9, 7, 3, 10, 5, 0}, {15, 12, 8, 2, 4, 9, 1, 7, 5, 11, 3, 14, 10, 0, 6, 13}};
5252

53-
private static int[][] s2 = {{15, 1, 8, 14, 6, 11, 3, 4, 9, 7, 2, 13, 12, 0, 5, 10}, {3, 13, 4, 7, 15, 2, 8, 14, 12, 0, 1, 10, 6, 9, 11, 5}, {0, 14, 7, 11, 10, 4, 13, 1, 5, 8, 12, 6, 9, 3, 2, 15}, {13, 8, 10, 1, 3, 15, 4, 2, 11, 6, 7, 12, 0, 5, 14, 9}};
53+
private static final int[][] S2 = {{15, 1, 8, 14, 6, 11, 3, 4, 9, 7, 2, 13, 12, 0, 5, 10}, {3, 13, 4, 7, 15, 2, 8, 14, 12, 0, 1, 10, 6, 9, 11, 5}, {0, 14, 7, 11, 10, 4, 13, 1, 5, 8, 12, 6, 9, 3, 2, 15}, {13, 8, 10, 1, 3, 15, 4, 2, 11, 6, 7, 12, 0, 5, 14, 9}};
5454

55-
private static int[][] s3 = {{10, 0, 9, 14, 6, 3, 15, 5, 1, 13, 12, 7, 11, 4, 2, 8}, {13, 7, 0, 9, 3, 4, 6, 10, 2, 8, 5, 14, 12, 11, 15, 1}, {13, 6, 4, 9, 8, 15, 3, 0, 11, 1, 2, 12, 5, 10, 14, 7}, {1, 10, 13, 0, 6, 9, 8, 7, 4, 15, 14, 3, 11, 5, 2, 12}};
55+
private static final int[][] S3 = {{10, 0, 9, 14, 6, 3, 15, 5, 1, 13, 12, 7, 11, 4, 2, 8}, {13, 7, 0, 9, 3, 4, 6, 10, 2, 8, 5, 14, 12, 11, 15, 1}, {13, 6, 4, 9, 8, 15, 3, 0, 11, 1, 2, 12, 5, 10, 14, 7}, {1, 10, 13, 0, 6, 9, 8, 7, 4, 15, 14, 3, 11, 5, 2, 12}};
5656

57-
private static int[][] s4 = {{7, 13, 14, 3, 0, 6, 9, 10, 1, 2, 8, 5, 11, 12, 4, 15}, {13, 8, 11, 5, 6, 15, 0, 3, 4, 7, 2, 12, 1, 10, 14, 9}, {10, 6, 9, 0, 12, 11, 7, 13, 15, 1, 3, 14, 5, 2, 8, 4}, {3, 15, 0, 6, 10, 1, 13, 8, 9, 4, 5, 11, 12, 7, 2, 14}};
57+
private static final int[][] S4 = {{7, 13, 14, 3, 0, 6, 9, 10, 1, 2, 8, 5, 11, 12, 4, 15}, {13, 8, 11, 5, 6, 15, 0, 3, 4, 7, 2, 12, 1, 10, 14, 9}, {10, 6, 9, 0, 12, 11, 7, 13, 15, 1, 3, 14, 5, 2, 8, 4}, {3, 15, 0, 6, 10, 1, 13, 8, 9, 4, 5, 11, 12, 7, 2, 14}};
5858

59-
private static int[][] s5 = {{2, 12, 4, 1, 7, 10, 11, 6, 8, 5, 3, 15, 13, 0, 14, 9}, {14, 11, 2, 12, 4, 7, 13, 1, 5, 0, 15, 10, 3, 9, 8, 6}, {4, 2, 1, 11, 10, 13, 7, 8, 15, 9, 12, 5, 6, 3, 0, 14}, {11, 8, 12, 7, 1, 14, 2, 13, 6, 15, 0, 9, 10, 4, 5, 3}};
59+
private static final int[][] S5 = {{2, 12, 4, 1, 7, 10, 11, 6, 8, 5, 3, 15, 13, 0, 14, 9}, {14, 11, 2, 12, 4, 7, 13, 1, 5, 0, 15, 10, 3, 9, 8, 6}, {4, 2, 1, 11, 10, 13, 7, 8, 15, 9, 12, 5, 6, 3, 0, 14}, {11, 8, 12, 7, 1, 14, 2, 13, 6, 15, 0, 9, 10, 4, 5, 3}};
6060

61-
private static int[][] s6 = {{12, 1, 10, 15, 9, 2, 6, 8, 0, 13, 3, 4, 14, 7, 5, 11}, {10, 15, 4, 2, 7, 12, 9, 5, 6, 1, 13, 14, 0, 11, 3, 8}, {9, 14, 15, 5, 2, 8, 12, 3, 7, 0, 4, 10, 1, 13, 11, 6}, {4, 3, 2, 12, 9, 5, 15, 10, 11, 14, 1, 7, 6, 0, 8, 13}};
61+
private static final int[][] S6 = {{12, 1, 10, 15, 9, 2, 6, 8, 0, 13, 3, 4, 14, 7, 5, 11}, {10, 15, 4, 2, 7, 12, 9, 5, 6, 1, 13, 14, 0, 11, 3, 8}, {9, 14, 15, 5, 2, 8, 12, 3, 7, 0, 4, 10, 1, 13, 11, 6}, {4, 3, 2, 12, 9, 5, 15, 10, 11, 14, 1, 7, 6, 0, 8, 13}};
6262

63-
private static int[][] s7 = {{4, 11, 2, 14, 15, 0, 8, 13, 3, 12, 9, 7, 5, 10, 6, 1}, {13, 0, 11, 7, 4, 9, 1, 10, 14, 3, 5, 12, 2, 15, 8, 6}, {1, 4, 11, 13, 12, 3, 7, 14, 10, 15, 6, 8, 0, 5, 9, 2}, {6, 11, 13, 8, 1, 4, 10, 7, 9, 5, 0, 15, 14, 2, 3, 12}};
63+
private static final int[][] S7 = {{4, 11, 2, 14, 15, 0, 8, 13, 3, 12, 9, 7, 5, 10, 6, 1}, {13, 0, 11, 7, 4, 9, 1, 10, 14, 3, 5, 12, 2, 15, 8, 6}, {1, 4, 11, 13, 12, 3, 7, 14, 10, 15, 6, 8, 0, 5, 9, 2}, {6, 11, 13, 8, 1, 4, 10, 7, 9, 5, 0, 15, 14, 2, 3, 12}};
6464

65-
private static int[][] s8 = {{13, 2, 8, 4, 6, 15, 11, 1, 10, 9, 3, 14, 5, 0, 12, 7}, {1, 15, 13, 8, 10, 3, 7, 4, 12, 5, 6, 11, 0, 14, 9, 2}, {7, 11, 4, 1, 9, 12, 14, 2, 0, 6, 10, 13, 15, 3, 5, 8}, {2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11}};
65+
private static final int[][] S8 = {{13, 2, 8, 4, 6, 15, 11, 1, 10, 9, 3, 14, 5, 0, 12, 7}, {1, 15, 13, 8, 10, 3, 7, 4, 12, 5, 6, 11, 0, 14, 9, 2}, {7, 11, 4, 1, 9, 12, 14, 2, 0, 6, 10, 13, 15, 3, 5, 8}, {2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11}};
6666

67-
private static int[][][] s = {s1, s2, s3, s4, s5, s6, s7, s8};
67+
private static final int[][][] S = {S1, S2, S3, S4, S5, S6, S7, S8};
6868

69-
// Permutation table, used in the feistel function post s-box usage
70-
static int[] permutation = {16, 7, 20, 21, 29, 12, 28, 17, 1, 15, 23, 26, 5, 18, 31, 10, 2, 8, 24, 14, 32, 27, 3, 9, 19, 13, 30, 6, 22, 11, 4, 25};
69+
// Permutation table, used in the Feistel function post s-box usage
70+
static final int[] PERMUTATION = {16, 7, 20, 21, 29, 12, 28, 17, 1, 15, 23, 26, 5, 18, 31, 10, 2, 8, 24, 14, 32, 27, 3, 9, 19, 13, 30, 6, 22, 11, 4, 25};
7171

7272
// Table used for final inversion of the message box after 16 rounds of Feistel Function
73-
static int[] IPinverse = {40, 8, 48, 16, 56, 24, 64, 32, 39, 7, 47, 15, 55, 23, 63, 31, 38, 6, 46, 14, 54, 22, 62, 30, 37, 5, 45, 13, 53, 21, 61, 29, 36, 4, 44, 12, 52, 20, 60, 28, 35, 3, 43, 11, 51, 19, 59, 27, 34, 2, 42, 10, 50, 18, 58, 26, 33, 1, 41, 9, 49, 17, 57, 25};
73+
static final int[] IP_INVERSE = {40, 8, 48, 16, 56, 24, 64, 32, 39, 7, 47, 15, 55, 23, 63, 31, 38, 6, 46, 14, 54, 22, 62, 30, 37, 5, 45, 13, 53, 21, 61, 29, 36, 4, 44, 12, 52, 20, 60, 28, 35, 3, 43, 11, 51, 19, 59, 27, 34, 2, 42, 10, 50, 18, 58, 26, 33, 1, 41, 9, 49, 17, 57, 25};
7474

7575
private String[] getSubkeys(String originalKey) {
76-
StringBuilder permutedKey = new StringBuilder(); // Initial permutation of keys via PC1
76+
StringBuilder permutedKey = new StringBuilder(); // Initial permutation of keys via pc1
7777
int i, j;
7878
for (i = 0; i < 56; i++) {
7979
permutedKey.append(originalKey.charAt(PC1[i] - 1));
@@ -91,7 +91,7 @@ private String[] getSubkeys(String originalKey) {
9191
D0 = Dn;
9292
}
9393

94-
// Let us shrink the keys to 48 bits (well, characters here) using PC2
94+
// Let us shrink the keys to 48 bits (well, characters here) using pc2
9595
for (i = 0; i < 16; i++) {
9696
String key = subKeys[i];
9797
permutedKey.setLength(0);
@@ -137,7 +137,7 @@ private String feistel(String messageBlock, String key) {
137137
int i;
138138
StringBuilder expandedKey = new StringBuilder();
139139
for (i = 0; i < 48; i++) {
140-
expandedKey.append(messageBlock.charAt(expansion[i] - 1));
140+
expandedKey.append(messageBlock.charAt(EXPANSION[i] - 1));
141141
}
142142
String mixedKey = XOR(expandedKey.toString(), key);
143143
StringBuilder substitutedString = new StringBuilder();
@@ -147,13 +147,13 @@ private String feistel(String messageBlock, String key) {
147147
String block = mixedKey.substring(i, i + 6);
148148
int row = (block.charAt(0) - 48) * 2 + (block.charAt(5) - 48);
149149
int col = (block.charAt(1) - 48) * 8 + (block.charAt(2) - 48) * 4 + (block.charAt(3) - 48) * 2 + (block.charAt(4) - 48);
150-
String substitutedBlock = pad(Integer.toBinaryString(s[i / 6][row][col]), 4);
150+
String substitutedBlock = pad(Integer.toBinaryString(S[i / 6][row][col]), 4);
151151
substitutedString.append(substitutedBlock);
152152
}
153153

154154
StringBuilder permutedString = new StringBuilder();
155155
for (i = 0; i < 32; i++) {
156-
permutedString.append(substitutedString.charAt(permutation[i] - 1));
156+
permutedString.append(substitutedString.charAt(PERMUTATION[i] - 1));
157157
}
158158

159159
return permutedString.toString();
@@ -178,7 +178,7 @@ private String encryptBlock(String message, String[] keys) {
178178
String combinedBlock = R0 + L0; // Reverse the 16th block
179179
permutedMessage.setLength(0);
180180
for (i = 0; i < 64; i++) {
181-
permutedMessage.append(combinedBlock.charAt(IPinverse[i] - 1));
181+
permutedMessage.append(combinedBlock.charAt(IP_INVERSE[i] - 1));
182182
}
183183
return permutedMessage.toString();
184184
}

‎src/main/java/com/thealgorithms/dynamicprogramming/FordFulkerson.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ private FordFulkerson() {
1010

1111
static final int INF = 987654321;
1212
// edges
13-
static int V;
13+
static int vertexCount;
1414
static int[][] capacity, flow;
1515

1616
public static void main(String[] args) {
17-
System.out.println("V : 6");
18-
V = 6;
19-
capacity = new int[V][V];
17+
System.out.println("Vertex Count : 6");
18+
vertexCount = 6;
19+
capacity = new int[vertexCount][vertexCount];
2020

2121
capacity[0][1] = 12;
2222
capacity[0][3] = 13;
@@ -32,11 +32,11 @@ public static void main(String[] args) {
3232
}
3333

3434
private static int networkFlow(int source, int sink) {
35-
flow = new int[V][V];
35+
flow = new int[vertexCount][vertexCount];
3636
int totalFlow = 0;
3737
while (true) {
38-
Vector<Integer> parent = new Vector<>(V);
39-
for (int i = 0; i < V; i++) {
38+
Vector<Integer> parent = new Vector<>(vertexCount);
39+
for (int i = 0; i < vertexCount; i++) {
4040
parent.add(-1);
4141
}
4242
Queue<Integer> q = new LinkedList<>();
@@ -45,7 +45,7 @@ private static int networkFlow(int source, int sink) {
4545
while (!q.isEmpty() && parent.get(sink) == -1) {
4646
int here = q.peek();
4747
q.poll();
48-
for (int there = 0; there < V; ++there) {
48+
for (int there = 0; there < vertexCount; ++there) {
4949
if (capacity[here][there] - flow[here][there] > 0 && parent.get(there) == -1) {
5050
q.add(there);
5151
parent.set(there, here);

‎src/main/java/com/thealgorithms/others/RabinKarp.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ public final class RabinKarp {
1111
private RabinKarp() {
1212
}
1313

14-
public static Scanner SCANNER = null;
14+
public static Scanner scanner = null;
1515
public static final int ALPHABET_SIZE = 256;
1616

1717
public static void main(String[] args) {
18-
SCANNER = new Scanner(System.in);
18+
scanner = new Scanner(System.in);
1919
System.out.println("Enter String");
20-
String text = SCANNER.nextLine();
20+
String text = scanner.nextLine();
2121
System.out.println("Enter pattern");
22-
String pattern = SCANNER.nextLine();
22+
String pattern = scanner.nextLine();
2323

2424
int q = 101;
2525
searchPat(text, pattern, q);

‎src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
*/
66
import java.util.Scanner;
77

8-
// An implementaion of string matching using finite automata
8+
// An implementation of string matching using finite automata
99
public final class StringMatchFiniteAutomata {
1010
private StringMatchFiniteAutomata() {
1111
}
1212

1313
public static final int CHARS = 256;
14-
public static int[][] FA;
14+
public static int[][] fa;
1515
public static Scanner scanner = null;
1616

1717
public static void main(String[] args) {
@@ -30,25 +30,25 @@ public static void searchPat(String text, String pat) {
3030
int m = pat.length();
3131
int n = text.length();
3232

33-
FA = new int[m + 1][CHARS];
33+
fa = new int[m + 1][CHARS];
3434

35-
computeFA(pat, m, FA);
35+
computeFA(pat, m, fa);
3636

3737
int state = 0;
3838
for (int i = 0; i < n; i++) {
39-
state = FA[state][text.charAt(i)];
39+
state = fa[state][text.charAt(i)];
4040

4141
if (state == m) {
4242
System.out.println("Pattern found at index " + (i - m + 1));
4343
}
4444
}
4545
}
4646

47-
// Computes finite automata for the partern
48-
public static void computeFA(String pat, int m, int[][] FA) {
47+
// Computes finite automata for the pattern
48+
public static void computeFA(String pat, int m, int[][] fa) {
4949
for (int state = 0; state <= m; ++state) {
5050
for (int x = 0; x < CHARS; ++x) {
51-
FA[state][x] = getNextState(pat, m, state, x);
51+
fa[state][x] = getNextState(pat, m, state, x);
5252
}
5353
}
5454
}

0 commit comments

Comments
 (0)