✅ Add found flag to chmod tests to prevent vacuous assertions

All 35 for_each_entry calls that match entries by path now track
whether the target entry was actually found, preventing tests from
silently passing when the target entry is missing from the archive.

Author: ChanTsune

cli/tests/cli/chmod/edge_cases.rs

@@ -36,8 +36,10 @@ fn chmod_edge_set_no_permissions() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_000.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -50,6 +52,7 @@ fn chmod_edge_set_no_permissions() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o000 (---------).
@@ -83,8 +86,10 @@ fn chmod_edge_set_full_permissions() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_777.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -97,6 +102,7 @@ fn chmod_edge_set_full_permissions() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o644 (rw-r--r--).
@@ -130,8 +136,10 @@ fn chmod_edge_idempotent_operation() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_idem.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -144,6 +152,7 @@ fn chmod_edge_idempotent_operation() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o755 (rwxr-xr-x).
@@ -177,8 +186,10 @@ fn chmod_edge_symbolic_clear_all() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_clear.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -191,6 +202,7 @@ fn chmod_edge_symbolic_clear_all() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o000 (---------).
@@ -224,8 +236,10 @@ fn chmod_edge_symbolic_full_permissions() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_full.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -238,6 +252,7 @@ fn chmod_edge_symbolic_full_permissions() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o755 (rwxr-xr-x).
@@ -272,8 +287,10 @@ fn chmod_edge_idempotent_add_execute() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_idem_x.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -286,6 +303,7 @@ fn chmod_edge_idempotent_add_execute() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o644 (rw-r--r--).
@@ -320,8 +338,10 @@ fn chmod_edge_idempotent_remove_execute() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_edge_idem_no_x.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -334,4 +354,5 @@ fn chmod_edge_idempotent_remove_execute() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/glob_pattern.rs

@@ -237,8 +237,10 @@ fn chmod_verify_archive_metadata() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_verify_meta.pna", |entry| {
         if entry.header().path() == "test.txt" {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -251,4 +253,5 @@ fn chmod_verify_archive_metadata() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/keep_solid.rs

@@ -38,8 +38,10 @@ fn chmod_keep_solid() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_keep_solid.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -52,4 +54,5 @@ fn chmod_keep_solid() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/multiple_clauses.rs

@@ -36,8 +36,10 @@ fn chmod_multiple_clauses_standard_754() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_multi_754.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -50,6 +52,7 @@ fn chmod_multiple_clauses_standard_754() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o777 (rwxrwxrwx).
@@ -83,8 +86,10 @@ fn chmod_multiple_clauses_restrictive() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_multi_640.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -97,6 +102,7 @@ fn chmod_multiple_clauses_restrictive() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o644 (rw-r--r--).
@@ -130,8 +136,10 @@ fn chmod_multiple_clauses_mixed_operations() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_multi_mixed.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -144,6 +152,7 @@ fn chmod_multiple_clauses_mixed_operations() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o777 (rwxrwxrwx).
@@ -177,8 +186,10 @@ fn chmod_multiple_clauses_combined_targets() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_multi_combined.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -191,4 +202,5 @@ fn chmod_multiple_clauses_combined_targets() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/numeric.rs

@@ -36,8 +36,10 @@ fn chmod_numeric_mode() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_numeric.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -50,4 +52,5 @@ fn chmod_numeric_mode() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/password.rs

@@ -41,8 +41,10 @@ fn chmod_with_password() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry_with_password("chmod_password.pna", Some(PASSWORD), |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -55,4 +57,5 @@ fn chmod_with_password() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/password_file.rs

@@ -45,8 +45,10 @@ fn chmod_with_password_file() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry_with_password("chmod_password_file.pna", Some(PASSWORD), |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -59,4 +61,5 @@ fn chmod_with_password_file() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }

cli/tests/cli/chmod/symbolic_all.rs

@@ -37,8 +37,10 @@ fn chmod_symbolic_all_implicit_add_execute() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_sym_all_add_x.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -51,6 +53,7 @@ fn chmod_symbolic_all_implicit_add_execute() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o666 (rw-rw-rw-).
@@ -84,8 +87,10 @@ fn chmod_symbolic_all_explicit_add_execute() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_sym_a_add_x.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -98,6 +103,7 @@ fn chmod_symbolic_all_explicit_add_execute() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o777 (rwxrwxrwx).
@@ -131,8 +137,10 @@ fn chmod_symbolic_all_remove_write() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_sym_a_rm_w.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -145,6 +153,7 @@ fn chmod_symbolic_all_remove_write() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }
 
 /// Precondition: An archive contains a file with permission 0o000 (---------).
@@ -179,8 +188,10 @@ fn chmod_symbolic_all_set_readwrite() {
     .execute()
     .unwrap();
 
+    let mut found = false;
     archive::for_each_entry("chmod_sym_all_set_rw.pna", |entry| {
         if entry.header().path() == ENTRY_PATH {
+            found = true;
             let perm = entry
                 .metadata()
                 .permission()
@@ -193,4 +204,5 @@ fn chmod_symbolic_all_set_readwrite() {
         }
     })
     .unwrap();
+    assert!(found, "target entry not found in archive");
 }