Skip to content

🐎 Add ChunkExt::write_chunk_in_async, SealedEntryExt::write_in_async for reduce copy#1322

Draft
ChanTsune wants to merge 1 commit into
mainfrom
lib/enhance-async-support
Draft

🐎 Add ChunkExt::write_chunk_in_async, SealedEntryExt::write_in_async for reduce copy#1322
ChanTsune wants to merge 1 commit into
mainfrom
lib/enhance-async-support

Conversation

@ChanTsune

@ChanTsune ChanTsune commented Dec 21, 2024

Copy link
Copy Markdown
Owner

No description provided.

@github-actions github-actions Bot added the lib This issue is about lib crate label Dec 21, 2024
@ChanTsune ChanTsune changed the title 🐎 Add ChunkExt::write_chunk_in_async, `SealedEntryExt::wr… 🐎 Add ChunkExt::write_chunk_in_async, SealedEntryExt::write_in_async for reduce copy Dec 21, 2024
Comment thread lib/src/entry.rs
fn into_chunks(self) -> Vec<RawChunk>;
fn write_in<W: Write>(&self, writer: &mut W) -> io::Result<usize>;
#[cfg(feature = "unstable-async")]
async fn write_in_async<W: futures_io::AsyncWrite + std::marker::Unpin>(

Check warning

Code scanning / clippy

use of async fn in public traits is discouraged as auto trait bounds cannot be specified Warning

use of async fn in public traits is discouraged as auto trait bounds cannot be specified
@ChanTsune
ChanTsune force-pushed the lib/enhance-async-support branch from a69ab7b to 363eb11 Compare February 5, 2025 08:28
@ChanTsune
ChanTsune marked this pull request as draft March 14, 2025 02:17
@ChanTsune
ChanTsune force-pushed the lib/enhance-async-support branch 2 times, most recently from 54af7db to 1a97856 Compare November 22, 2025 05:24
@ChanTsune
ChanTsune force-pushed the lib/enhance-async-support branch from 1a97856 to 68d001f Compare May 14, 2026 11:50
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bbbd5754-315e-468e-bcc4-f7add92984c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lib/enhance-async-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread lib/src/chunk.rs Fixed
Comment thread lib/src/chunk.rs Fixed
Comment thread lib/src/entry.rs Fixed
Comment thread lib/src/entry.rs Fixed
@ChanTsune
ChanTsune force-pushed the lib/enhance-async-support branch from 68d001f to 397b6e7 Compare May 14, 2026 13:32
Comment thread lib/src/entry.rs
fn into_chunks(self) -> Vec<RawChunk>;
fn write_in<W: Write>(&self, writer: &mut W) -> io::Result<usize>;
#[cfg(feature = "unstable-async")]
async fn write_in_async<W: futures_io::AsyncWrite + std::marker::Unpin>(

Check warning

Code scanning / clippy

use of async fn in public traits is discouraged as auto trait bounds cannot be specified Warning

use of async fn in public traits is discouraged as auto trait bounds cannot be specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib This issue is about lib crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants