🚧 Add EntryName::from_absolute_path_lossy#2191
Conversation
Summary of ChangesHello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new function EntryName::from_absolute_utf8path for creating an EntryName while preserving absolute path components, and refactors path sanitization logic into a new helper function. The changes are well-structured and improve the codebase. I have a couple of suggestions to enhance the new API's clarity and to make a helper function more idiomatic.
f8b41ba to
f559ab8
Compare
f559ab8 to
092f57d
Compare
eb2414e to
74eded9
Compare
27ed47e to
2e77e6a
Compare
2e77e6a to
a05d03c
Compare
6edf195 to
7c0c151
Compare
…y}_preserve_root`
879b3b5 to
af17720
Compare
…,path_lossy}_preserve_root`
af17720 to
ad77480
Compare
|
close #2177 |
No description provided.