💥 Remove deprecated apis since 0.27.x#2370
Conversation
Summary of ChangesHello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the codebase by removing an API that was previously marked as deprecated. This action aligns with the project's deprecation policy, ensuring that the API surface remains current and maintainable, and prepares the codebase for the upcoming 0.31.0 release by eliminating outdated functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated EntryBuilder::new_symbolic_link function. This is a good cleanup of the API, making the codebase more maintainable by removing code that was already marked for removal. The change is correct and aligns with the goal of removing deprecated APIs for a future release.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request removes a deprecated public method Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Will be removed in 0.31.0
Summary by CodeRabbit