Skip to content

💥 Remove deprecated apis since 0.27.x#2370

Merged
ChanTsune merged 1 commit into
mainfrom
lib/remove-deprecated-apis-since-0.27.x
Feb 11, 2026
Merged

💥 Remove deprecated apis since 0.27.x#2370
ChanTsune merged 1 commit into
mainfrom
lib/remove-deprecated-apis-since-0.27.x

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

@ChanTsune ChanTsune commented Nov 22, 2025 •
edited by coderabbitai Bot
Loading

Will be removed in 0.31.0

Summary by CodeRabbit

  • Chores
    • Removed previously deprecated functionality for creating symbolic links. Users relying on the older method should migrate to the current equivalent.

@ChanTsune ChanTsune marked this pull request as draft November 22, 2025 05:53
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Nov 22, 2025

Summary of Changes

Hello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the codebase by removing an API that was previously marked as deprecated. This action aligns with the project's deprecation policy, ensuring that the API surface remains current and maintainable, and prepares the codebase for the upcoming 0.31.0 release by eliminating outdated functionality.

Highlights

  • API Deprecation Removal: The EntryBuilder::new_symbolic_link function has been removed from lib/src/entry/builder.rs. This function was previously marked as deprecated since version 0.27.2, with EntryBuilder::new_symlink as its recommended replacement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated EntryBuilder::new_symbolic_link function. This is a good cleanup of the API, making the codebase more maintainable by removing code that was already marked for removal. The change is correct and aligns with the goal of removing deprecated APIs for a future release.

@github-actions github-actions Bot added lib This issue is about lib crate break API braking change labels Nov 22, 2025
@ChanTsune ChanTsune marked this pull request as ready for review February 11, 2026 02:58
@ChanTsune ChanTsune merged commit 18d0942 into main Feb 11, 2026
98 of 99 checks passed
@ChanTsune ChanTsune deleted the lib/remove-deprecated-apis-since-0.27.x branch February 11, 2026 02:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 11, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request removes a deprecated public method new_symbolic_link from the EntryBuilder struct, which was a wrapper that delegated to the new_symlink method. This eliminates the public alias and completes the deprecation cycle.

Changes

Cohort / File(s) Summary
Deprecated API Removal
lib/src/entry/builder.rs		 Removed the deprecated new_symbolic_link public constructor method (20 lines). Functionality is available through new_symlink directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 An old path fades away so neat,
The deprecated link's no longer fleet,
With new_symlink standing strong and true,
We hop ahead to cleaner code anew! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lib/remove-deprecated-apis-since-0.27.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot mentioned this pull request Apr 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

break API braking change lib This issue is about lib crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChanTsune