Skip to content

💥 Remove deprecated apis since 0.28.x#2371

Merged
ChanTsune merged 1 commit into
mainfrom
lib/remove-deprecated-apis-since-0.28.x
Apr 23, 2026
Merged

💥 Remove deprecated apis since 0.28.x#2371
ChanTsune merged 1 commit into
mainfrom
lib/remove-deprecated-apis-since-0.28.x

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

Will be removed in 0.32.0

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine cleanup by removing a deprecated API, specifically the entries_skip_solid method. This action aligns with the project's deprecation policy, ensuring that the codebase remains modern and maintainable by eliminating functionalities that have been superseded or are no longer recommended for use, as planned for removal in version 0.32.0.

Highlights

  • API Removal: The entries_skip_solid method has been removed from the Archive<R> struct in lib/src/archive/read.rs. This method was previously marked as deprecated since version 0.28.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ChanTsune ChanTsune marked this pull request as draft November 22, 2025 05:55
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the entries_skip_solid function, which was deprecated in version 0.28.1. This is a good cleanup of the public API. I've added one suggestion related to API consistency, proposing the deprecation of a similar helper function to align with the design direction this change promotes.

@github-actions github-actions Bot added lib This issue is about lib crate break API braking change labels Nov 22, 2025
@ChanTsune ChanTsune force-pushed the lib/remove-deprecated-apis-since-0.28.x branch from 520c4e1 to cb45886 Compare April 22, 2026 09:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3468e9ec-e6d4-4871-bfe5-bd5ba0a5cb6b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lib/remove-deprecated-apis-since-0.28.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChanTsune ChanTsune marked this pull request as ready for review April 22, 2026 10:09
@ChanTsune ChanTsune merged commit 98ae744 into main Apr 23, 2026
114 of 115 checks passed
@ChanTsune ChanTsune deleted the lib/remove-deprecated-apis-since-0.28.x branch April 23, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

break API braking change lib This issue is about lib crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant