Skip to content

👽 use recommended API for assert_cmd#2376

Merged
ChanTsune merged 1 commit into
mainfrom
test/cli/migrate-assert-cmd
Nov 24, 2025
Merged

👽 use recommended API for assert_cmd#2376
ChanTsune merged 1 commit into
mainfrom
test/cli/migrate-assert-cmd

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the test suite to adopt the recommended API for the assert_cmd crate. By switching to the cargo_bin_cmd! macro, the tests now leverage a more idiomatic and potentially more robust way to execute cargo binaries, ensuring better alignment with the library's best practices.

Highlights

  • assert_cmd API Update: Updated test files to use the cargo_bin_cmd! macro from the assert_cmd crate, replacing the older Command::cargo_bin().unwrap() pattern for spawning cargo binaries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test file cli/tests/cli/stdio/unlink_first.rs to use the recommended cargo_bin_cmd! macro from the assert_cmd crate. This change replaces the previous Command::cargo_bin(...).unwrap() calls, leading to cleaner and more idiomatic test code. The update is implemented correctly and is a good improvement.

@github-actions github-actions Bot added the cli This issue is about cli application label Nov 24, 2025
@ChanTsune ChanTsune merged commit db420aa into main Nov 24, 2025
138 of 141 checks passed
@ChanTsune ChanTsune deleted the test/cli/migrate-assert-cmd branch November 24, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli This issue is about cli application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant