👕 simplify bool checks

[ChanTsune]

clippy::nonminimal_bool

[gemini-code-assist]

Summary of Changes

Hello @ChanTsune, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code readability and adhering to best practices by simplifying boolean expressions across several test files. It addresses the clippy::nonminimal_bool lint by refactoring complex boolean checks into more concise and direct forms, making the code easier to understand and maintain without altering its functional behavior.

Highlights

• Boolean Simplification: Replaced !result.is_ok() with result.is_err() for more idiomatic and readable error checking in file metadata assertions.
• Inequality Logic: Transformed !(a <= b) into a > b to simplify inequality comparisons, improving clarity in conditional statements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies boolean checks in test files, addressing the clippy::nonminimal_bool lint. The changes replace negated conditions with their more direct and readable counterparts, such as !result.is_ok() with result.is_err() and !(a <= b) with a > b. These are good, idiomatic improvements that enhance code clarity. The changes are correct and well-executed.