👕 drop needless borrows#2381
Conversation
`clippy::needless_borrows_for_generic_args`
Summary of ChangesHello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code cleanup and adherence to Rust's best practices by eliminating redundant borrow operations. The changes specifically target test functions in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses the clippy::needless_borrows_for_generic_args lint by removing unnecessary borrows when calling PathFilter::new in the test module. The changes are correct and improve code style by passing Copy types (arrays of &str) by value instead of by reference, which is more idiomatic in this context. The changes are confined to test code and look good.
clippy::needless_borrows_for_generic_args