Skip to content

👕 drop needless borrows#2381

Merged
ChanTsune merged 1 commit into
mainfrom
test/cli/clippy-needless_borrows_for_generic_args
Nov 25, 2025
Merged

👕 drop needless borrows#2381
ChanTsune merged 1 commit into
mainfrom
test/cli/clippy-needless_borrows_for_generic_args

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

clippy::needless_borrows_for_generic_args

`clippy::needless_borrows_for_generic_args`
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanup and adherence to Rust's best practices by eliminating redundant borrow operations. The changes specifically target test functions in cli/src/command/core.rs, where array arguments were being unnecessarily borrowed before being passed to the PathFilter::new constructor. This adjustment aligns the code with the clippy::needless_borrows_for_generic_args lint, resulting in cleaner and more idiomatic Rust.

Highlights

  • Code Refinement: Removed unnecessary explicit borrows (&) when passing array arguments to the PathFilter::new constructor within various test functions.
  • Clippy Compliance: Addressed the clippy::needless_borrows_for_generic_args lint, promoting more idiomatic Rust code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses the clippy::needless_borrows_for_generic_args lint by removing unnecessary borrows when calling PathFilter::new in the test module. The changes are correct and improve code style by passing Copy types (arrays of &str) by value instead of by reference, which is more idiomatic in this context. The changes are confined to test code and look good.

@github-actions github-actions Bot added the cli This issue is about cli application label Nov 24, 2025
@ChanTsune ChanTsune merged commit 4a57787 into main Nov 25, 2025
99 checks passed
@ChanTsune ChanTsune deleted the test/cli/clippy-needless_borrows_for_generic_args branch November 25, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli This issue is about cli application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant