🔧 use forked clap-markdown#2393
Conversation
Summary of ChangesHello @ChanTsune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the documentation generation process by switching to a custom-forked version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request switches the clap-markdown dependency to a forked version, which seems to include fixes for bugs that were previously worked around in the codebase. This has allowed for the removal of a significant amount of complex workaround code, greatly simplifying the docgen task. This is an excellent improvement.
I've added a couple of suggestions:
- In
xtask/Cargo.toml, I recommend pinning the git dependency to a specific commit hash instead of a branch name to ensure reproducible builds. - In
xtask/src/main.rs, I've suggested a small reordering in thedocgenfunction to fail faster if the output directory cannot be created.
No description provided.