Ci/add riscv runner#2894
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the libz-ng-sys dependency to version 1.1.25 and adds a new RISC-V runner label to the actionlint configuration. Feedback indicates that the implementation is currently incomplete because the GitHub Actions workflow files have not been updated to actually utilize the new runner.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/test.yml (1)
95-95: Consider adding a comment explaining whyzlib-ngis excluded on RISC-V.The exclusion is likely due to architecture-specific compilation issues with zlib-ng on RISC-V. A brief comment would help future maintainers understand this decision.
📝 Suggested documentation
env: RUST_BACKTRACE: 1 + # zlib-ng excluded on RISC-V due to compilation/architecture support issues EXCLUDE_FEATURES: ${{ contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm' }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/test.yml at line 95, Add a short inline comment above the EXCLUDE_FEATURES line in .github/workflows/test.yml explaining why zlib-ng is excluded on RISC-V (e.g., known architecture-specific build/compatibility issues or a referenced bug/PR), so maintainers know the rationale for the conditional EXCLUDE_FEATURES: ${{ contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm' }}; if there is a specific issue/PR or a brief error message, include that reference in the comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/test.yml:
- Around line 90-95: The GitHub Actions step named "run test" uses bash-style
env expansion for EXCLUDE_FEATURES which fails on Windows pwsh; update the step
that runs `cargo hack test ... --exclude-features "$EXCLUDE_FEATURES"` to
explicitly set shell: bash so the `$EXCLUDE_FEATURES` expansion works
cross-platform (keep the existing env entries RUST_BACKTRACE and
EXCLUDE_FEATURES unchanged); ensure the `shell: bash` line is added at the same
level as `run:` in the "run test" step.
---
Nitpick comments:
In @.github/workflows/test.yml:
- Line 95: Add a short inline comment above the EXCLUDE_FEATURES line in
.github/workflows/test.yml explaining why zlib-ng is excluded on RISC-V (e.g.,
known architecture-specific build/compatibility issues or a referenced bug/PR),
so maintainers know the rationale for the conditional EXCLUDE_FEATURES: ${{
contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm' }}; if there is a
specific issue/PR or a brief error message, include that reference in the
comment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c3ca4371-82b7-4fb5-b682-4ea83a5e5653
📒 Files selected for processing (1)
.github/workflows/test.yml
5d0a834 to
77001bb
Compare
zlib-ng has unresolved RISC-V issues (heap corruption from unaligned fastbin chunks) even in latest version (2.3.3). Skip zlib-ng feature in RISC-V test matrix until upstream fix is available.
77001bb to
87fa793
Compare
Summary by CodeRabbit