Skip to content

Ci/add riscv runner#2894

Open
ChanTsune wants to merge 5 commits into
mainfrom
ci/add-riscv-runner
Open

Ci/add riscv runner#2894
ChanTsune wants to merge 5 commits into
mainfrom
ci/add-riscv-runner

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

@ChanTsune ChanTsune commented Apr 1, 2026

Summary by CodeRabbit

  • Chores
    • Added lint configuration to recognize a self-hosted runner label for validation.
    • Expanded workflow triggers to monitor additional CI/configuration files so updates to tooling configs run linters.
    • Expanded the CI test matrix with a new Ubuntu RISC‑V runner and conditional job timeout for RISC‑V jobs.
    • Updated CI setup to install extra build tooling and made feature-exclusion configurable per runner type.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds an actionlint config declaring a ubuntu-24.04-riscv self-hosted-runner label, extends actions-lint workflow triggers to include .github/actionlint.yaml and .github/zizmor.yml, and updates CI (.github/workflows/test.yml) to add a RISC‑V matrix entry, conditional timeout, and install cmake with adjusted exclude features.

Changes

Cohort / File(s) Summary
Actionlint config
/.github/actionlint.yaml
New file: declares self-hosted-runner.labels: [ubuntu-24.04-riscv] for actionlint validation.
Lint workflow triggers
/.github/workflows/actions-lint.yml
Extend pull_request.paths and push.paths to also trigger on .github/actionlint.yaml and .github/zizmor.yml.
CI test workflow
/.github/workflows/test.yml
Add ubuntu-24.04-riscv to Tier 1 matrix; make timeout-minutes conditional (120 when matrix.os contains riscv, else 60); install cmake alongside libacl1-dev on Ubuntu/MSRV jobs; set EXCLUDE_FEATURES to wasm,zlib-ng for RISC‑V and wasm otherwise.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hopped into CI with a jaunty spin,
A tiny RISC‑V label tucked within,
Actionlint checks my tiny hat, hooray—
CMake joins the dance and tests make way,
Build carrots crisp, and bunnies bound to play.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Ci/add riscv runner' directly and clearly summarizes the main change: adding a RISC-V runner to CI configuration across workflow and configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/add-riscv-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file CI Pull requests that update CI config labels Apr 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the libz-ng-sys dependency to version 1.1.25 and adds a new RISC-V runner label to the actionlint configuration. Feedback indicates that the implementation is currently incomplete because the GitHub Actions workflow files have not been updated to actually utilize the new runner.

Comment thread .github/actionlint.yaml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/test.yml (1)

95-95: Consider adding a comment explaining why zlib-ng is excluded on RISC-V.

The exclusion is likely due to architecture-specific compilation issues with zlib-ng on RISC-V. A brief comment would help future maintainers understand this decision.

📝 Suggested documentation
        env:
          RUST_BACKTRACE: 1
+         # zlib-ng excluded on RISC-V due to compilation/architecture support issues
          EXCLUDE_FEATURES: ${{ contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm' }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test.yml at line 95, Add a short inline comment above the
EXCLUDE_FEATURES line in .github/workflows/test.yml explaining why zlib-ng is
excluded on RISC-V (e.g., known architecture-specific build/compatibility issues
or a referenced bug/PR), so maintainers know the rationale for the conditional
EXCLUDE_FEATURES: ${{ contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm'
}}; if there is a specific issue/PR or a brief error message, include that
reference in the comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/test.yml:
- Around line 90-95: The GitHub Actions step named "run test" uses bash-style
env expansion for EXCLUDE_FEATURES which fails on Windows pwsh; update the step
that runs `cargo hack test ... --exclude-features "$EXCLUDE_FEATURES"` to
explicitly set shell: bash so the `$EXCLUDE_FEATURES` expansion works
cross-platform (keep the existing env entries RUST_BACKTRACE and
EXCLUDE_FEATURES unchanged); ensure the `shell: bash` line is added at the same
level as `run:` in the "run test" step.

---

Nitpick comments:
In @.github/workflows/test.yml:
- Line 95: Add a short inline comment above the EXCLUDE_FEATURES line in
.github/workflows/test.yml explaining why zlib-ng is excluded on RISC-V (e.g.,
known architecture-specific build/compatibility issues or a referenced bug/PR),
so maintainers know the rationale for the conditional EXCLUDE_FEATURES: ${{
contains(matrix.os, 'riscv') && 'wasm,zlib-ng' || 'wasm' }}; if there is a
specific issue/PR or a brief error message, include that reference in the
comment.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3ca4371-82b7-4fb5-b682-4ea83a5e5653

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2fe2f and 32a14fc.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Comment thread .github/workflows/test.yml
@ChanTsune ChanTsune force-pushed the ci/add-riscv-runner branch 3 times, most recently from 5d0a834 to 77001bb Compare April 5, 2026 03:11
@ChanTsune ChanTsune force-pushed the ci/add-riscv-runner branch from 77001bb to 87fa793 Compare May 14, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Pull requests that update CI config dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant