Conversation
The migrate command has been moved out of experimental and is now a stable CLI subcommand. A deprecation warning is added to the `experimental migrate` alias to inform users to use the new stable `migrate` command, and related module visibility and command dispatch logic are updated accordingly. Mirrors the prior pattern applied to `sort` (f2f15d3) and `delete` (5417b47).
📝 WalkthroughWalkthroughThe PR stabilizes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cli/src/command/experimental.rs (1)
42-52: LGTM — mirrors the sort/delete stabilization pattern.The deprecation warning and the updated
abouttext forMigrateare consistent with the existingDeleteandSortbranches, and delegation tocmd.execute(ctx)preserves behavior for existing users.Minor nit (optional, not blocking): the warning string starts a new sentence with lowercase "this command will be removed…" after a period — this is pre-existing style shared across the Delete/Sort warnings, so keeping it consistent here is reasonable. If you want to polish these as a small follow-up, capitalizing "This" across all three messages would read slightly better.
Also applies to: 88-91
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cli/src/command/experimental.rs` around lines 42 - 52, The warning message in the ExperimentalCommands::Migrate branch uses a lowercase "this" after a period (mirroring the Delete/Sort branches) — update the log::warn message in ExperimentalCommands::Migrate and the analogous warning strings in the Delete and Sort branches to capitalize "This" so the sentence reads "...use `{0} migrate` instead. This command will be removed in the future."; keep the rest of the string and the delegation to cmd.execute(ctx) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@cli/src/command/experimental.rs`:
- Around line 42-52: The warning message in the ExperimentalCommands::Migrate
branch uses a lowercase "this" after a period (mirroring the Delete/Sort
branches) — update the log::warn message in ExperimentalCommands::Migrate and
the analogous warning strings in the Delete and Sort branches to capitalize
"This" so the sentence reads "...use `{0} migrate` instead. This command will be
removed in the future."; keep the rest of the string and the delegation to
cmd.execute(ctx) unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f6b5c63e-1eb2-4d76-832b-83a450c1b4ac
📒 Files selected for processing (3)
cli/src/cli.rscli/src/command.rscli/src/command/experimental.rs
There was a problem hiding this comment.
Code Review
This pull request stabilizes the migrate command by promoting it from an experimental subcommand to a top-level command. The experimental migrate command now includes a warning message advising users to transition to the new top-level command. Review feedback suggests minor grammatical and capitalization improvements to the warning messages and command descriptions for better consistency.
The migrate command has been moved out of experimental and is now a stable CLI subcommand. A deprecation warning is added to the
experimental migratealias to inform users to use the new stablemigratecommand, and related module visibility and command dispatch logic are updated accordingly. Mirrors the prior pattern applied tosort(f2f15d3) anddelete(5417b47).Summary by CodeRabbit
New Features
migratecommand to upgrade archives created by previous versions.Deprecations
migratesubcommand is now stabilized; use the standardmigratecommand instead.