✨ Add encoded entry data reader#3083
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 27 minutes and 10 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces the EncodedDataReader struct to provide a unified way to read raw, encoded entry data from FDAT and SDAT chunks before decryption or decompression. Both NormalEntry and SolidEntry now expose an encoded_reader() method, and internal components like EntryDataReader and EntryIterator have been refactored to utilize this new reader, simplifying type signatures and reducing code duplication. Additionally, unit tests were added to verify the correct behavior of the encoded readers for both entry types. I have no feedback to provide as there were no review comments.
No description provided.