Skip to content

✨ Add encoded entry data reader#3083

Merged
ChanTsune merged 1 commit into
mainfrom
api/encoded-data-reader
May 24, 2026
Merged

✨ Add encoded entry data reader#3083
ChanTsune merged 1 commit into
mainfrom
api/encoded-data-reader

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@ChanTsune, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 27 minutes and 10 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3848151-5eb6-4c4f-bde6-7b34c864ddd4

📥 Commits

Reviewing files that changed from the base of the PR and between 82b7983 and 854e837.

📒 Files selected for processing (1)
  • lib/src/entry.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch api/encoded-data-reader

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the EncodedDataReader struct to provide a unified way to read raw, encoded entry data from FDAT and SDAT chunks before decryption or decompression. Both NormalEntry and SolidEntry now expose an encoded_reader() method, and internal components like EntryDataReader and EntryIterator have been refactored to utilize this new reader, simplifying type signatures and reducing code duplication. Additionally, unit tests were added to verify the correct behavior of the encoded readers for both entry types. I have no feedback to provide as there were no review comments.

@github-actions github-actions Bot added the lib This issue is about lib crate label May 24, 2026
@ChanTsune ChanTsune merged commit 41e53c8 into main May 24, 2026
110 checks passed
@ChanTsune ChanTsune deleted the api/encoded-data-reader branch May 24, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib This issue is about lib crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant