Skip to content

Unify missing-time options into a single --missing-time option#3164

Merged
ChanTsune merged 4 commits into
mainfrom
cli/time-filter/unify-missing-time
Jul 6, 2026
Merged

Unify missing-time options into a single --missing-time option#3164
ChanTsune merged 4 commits into
mainfrom
cli/time-filter/unify-missing-time

Conversation

@ChanTsune

Copy link
Copy Markdown
Owner

Summary

Replaces --archive-missing-ctime/--archive-missing-mtime on list, extract, and update with a single --missing-time option that applies to every time judgment the command performs. All removed options were unstable.

Notes

  • On update the policy now also governs the staleness judgment when the filesystem mtime is unreadable (previously always treated as needing update) and the ctime side of the time filters (--archive-missing-ctime was declared but never consumed).
  • A time filter with no bounds no longer consults the policy; without this guard, --missing-time exclude alone would drop every entry through the unbounded ctime filter on filesystems without birth time.

ChanTsune added 4 commits July 5, 2026 22:37
Replaces --archive-missing-ctime/--archive-missing-mtime on list,
extract, and update. The single policy now feeds both the ctime and
mtime sides of the time filters, and update's staleness judgment.
On update the ctime side was previously declared but never consumed;
it now takes effect through the time-filter resolver.
Previously an unreadable filesystem mtime unconditionally forced an
update; the policy now decides both sides of the comparison.
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ChanTsune, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9ac037fd-daa7-4dfc-841c-4d9c6ce0fe63

📥 Commits

Reviewing files that changed from the base of the PR and between 5961e87 and c8c148b.

📒 Files selected for processing (11)
  • cli/src/command/core/time_filter.rs
  • cli/src/command/extract.rs
  • cli/src/command/list.rs
  • cli/src/command/update.rs
  • cli/tests/cli/extract.rs
  • cli/tests/cli/extract/option_missing_time.rs
  • cli/tests/cli/list.rs
  • cli/tests/cli/list/option_missing_time.rs
  • cli/tests/cli/update.rs
  • cli/tests/cli/update/option_archive_missing_mtime.rs
  • cli/tests/cli/update/option_missing_time.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cli/time-filter/unify-missing-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates the separate archive_missing_ctime and archive_missing_mtime CLI arguments into a single --missing-time option across the extract, list, and update commands. It also simplifies the internal time filtering logic by introducing an is_unbounded check on TimeRange to bypass missing-time policies when no bounds are specified, and updates is_newer_than_archive to return a boolean directly. Comprehensive integration tests have been added to verify the new --missing-time option behaviors.

Feedback is provided on a test in cli/tests/cli/list/option_missing_time.rs that uses an external process call to assert parsing failures. It is recommended to use in-process argument parsing validation instead to avoid false positives and improve test performance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cli/tests/cli/list/option_missing_time.rs
@github-actions github-actions Bot added cli This issue is about cli application break API braking change and removed break API braking change labels Jul 5, 2026
@ChanTsune
ChanTsune merged commit d223dac into main Jul 6, 2026
110 checks passed
@ChanTsune
ChanTsune deleted the cli/time-filter/unify-missing-time branch July 6, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli This issue is about cli application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant