Unify missing-time options into a single --missing-time option#3164
Conversation
Replaces --archive-missing-ctime/--archive-missing-mtime on list, extract, and update. The single policy now feeds both the ctime and mtime sides of the time filters, and update's staleness judgment. On update the ctime side was previously declared but never consumed; it now takes effect through the time-filter resolver.
Previously an unreadable filesystem mtime unconditionally forced an update; the policy now decides both sides of the comparison.
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request consolidates the separate archive_missing_ctime and archive_missing_mtime CLI arguments into a single --missing-time option across the extract, list, and update commands. It also simplifies the internal time filtering logic by introducing an is_unbounded check on TimeRange to bypass missing-time policies when no bounds are specified, and updates is_newer_than_archive to return a boolean directly. Comprehensive integration tests have been added to verify the new --missing-time option behaviors.
Feedback is provided on a test in cli/tests/cli/list/option_missing_time.rs that uses an external process call to assert parsing failures. It is recommended to use in-process argument parsing validation instead to avoid false positives and improve test performance.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Replaces
--archive-missing-ctime/--archive-missing-mtimeonlist,extract, andupdatewith a single--missing-timeoption that applies to every time judgment the command performs. All removed options were unstable.Notes
updatethe policy now also governs the staleness judgment when the filesystem mtime is unreadable (previously always treated as needing update) and the ctime side of the time filters (--archive-missing-ctimewas declared but never consumed).--missing-time excludealone would drop every entry through the unbounded ctime filter on filesystems without birth time.