Skip to content

Rename encoded_reader to raw_content - #3208

Closed
ChanTsune wants to merge 2 commits into
feat/entry-contentfrom
feat/raw-content
Closed

Rename encoded_reader to raw_content#3208
ChanTsune wants to merge 2 commits into
feat/entry-contentfrom
feat/raw-content

Conversation

@ChanTsune

Copy link
Copy Markdown
Owner

Summary

Rename encoded_reader to raw_content on NormalEntry and SolidEntry, aligning the raw-bytes accessor with the content() vocabulary introduced in #3207. The old name remains as a deprecated delegating alias.

Notes

  • #[deprecated(since = "0.36.0", note = "use raw_content() instead")] — behavior is identical (returns the encoded chunk body bytes before decryption/decompression).
  • Stacked on Add EntryContent decoded view for NormalEntry #3207 (feat/entry-content); retarget to main after it merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the encoded_reader method to raw_content on both SolidEntry and NormalEntry structs in lib/src/entry.rs. The old encoded_reader method is retained as a deprecated alias to maintain backwards compatibility. Internal usages and test cases have been updated to use the new raw_content method. There are no review comments to address, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions github-actions Bot added the lib This issue is about lib crate label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b2ee1baa-155a-4f6d-8909-e2952c06721b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/raw-content

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChanTsune

Copy link
Copy Markdown
Owner Author

Closing: keeping encoded_reader — the name matches the EncodedDataReader return type and the spec's encoder/decoder vocabulary, and none of the alternatives (raw_content, raw_reader, stored_reader) are more precise.

@ChanTsune ChanTsune closed this Jul 16, 2026
@ChanTsune
ChanTsune deleted the feat/raw-content branch July 16, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib This issue is about lib crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant