Address CodeRabbit review feedback (round 2)

Author: Jaben

examples/EncryptPdf/Program.cs

@@ -18,12 +18,13 @@
 
 var path = await CreateEncryptedPdf(destinationDirectory, options);
 Console.WriteLine($"Encrypted PDF created: {path}");
-Console.WriteLine("Open with password: reader123");
 
 static async Task<string> CreateEncryptedPdf(string destinationDirectory, GotenbergSharpClientOptions options)
 {
     var handler = new HttpClientHandler();
     HttpMessageHandler effectiveHandler = handler;
+    if (string.IsNullOrWhiteSpace(options.BasicAuthUsername) != string.IsNullOrWhiteSpace(options.BasicAuthPassword))
+        throw new InvalidOperationException("Both BasicAuthUsername and BasicAuthPassword must be provided, or neither.");
     if (!string.IsNullOrWhiteSpace(options.BasicAuthUsername) && !string.IsNullOrWhiteSpace(options.BasicAuthPassword))
         effectiveHandler = new BasicAuthHandler(options.BasicAuthUsername, options.BasicAuthPassword) { InnerHandler = handler };
 

src/Gotenberg.Sharp.Api.Client/Domain/Builders/Faceted/PdfOutputOptionsBuilder.cs

@@ -167,8 +167,12 @@ public PdfOutputOptionsBuilder SetOwnerPassword(string password)
     /// <returns>The builder instance for method chaining.</returns>
     public PdfOutputOptionsBuilder SetEncryption(string userPassword, string ownerPassword)
     {
-        SetUserPassword(userPassword);
-        SetOwnerPassword(ownerPassword);
+        // Validate both passwords first before mutating any state
+        var validatedUser = PdfPassword.Create(userPassword);
+        var validatedOwner = PdfPassword.Create(ownerPassword);
+
+        _options.UserPassword = validatedUser;
+        _options.OwnerPassword = validatedOwner;
 
         return this;
     }

src/Gotenberg.Sharp.Api.Client/Domain/Requests/Facets/FacetBase.cs

@@ -15,6 +15,8 @@
 
 using System.Globalization;
 
+using Gotenberg.Sharp.API.Client.Domain.ValueObjects;
+
 namespace Gotenberg.Sharp.API.Client.Domain.Requests.Facets;
 
 public abstract class FacetBase : IConvertToHttpContent
@@ -77,6 +79,7 @@ public virtual IEnumerable<HttpContent> ToHttpContent()
             PdfFormat format => format.ToFormDataValue(),
             LibrePdfFormats format => format.ToFormDataValue(),
             ConversionPdfFormats format => format.ToFormDataValue(),
+            PdfPassword password => password.Value,
             List<Cookie> cookies => JsonConvert.SerializeObject(cookies),
             float f => f.ToString(cultureInfo),
             double d => d.ToString(cultureInfo),

src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/PdfPassword.cs

@@ -41,16 +41,14 @@ public static PdfPassword Create(string password)
         return new PdfPassword(password);
     }
 
-    public override string ToString() => Value;
+    public override string ToString() => "****";
 
     public bool Equals(PdfPassword? other) => other is not null && Value == other.Value;
 
     public override bool Equals(object? obj) => Equals(obj as PdfPassword);
 
     public override int GetHashCode() => Value.GetHashCode();
 
-    public static implicit operator string(PdfPassword password) => password.Value;
-
     public static bool operator ==(PdfPassword? left, PdfPassword? right) => Equals(left, right);
 
     public static bool operator !=(PdfPassword? left, PdfPassword? right) => !Equals(left, right);

test/GotenbergSharpClient.Tests/EncryptionOptionsTests.cs

@@ -4,6 +4,7 @@
 using Gotenberg.Sharp.API.Client.Domain.Settings;
 using Gotenberg.Sharp.API.Client.Domain.ValueObjects;
 using Gotenberg.Sharp.API.Client.Extensions;
+using Gotenberg.Sharp.API.Client.Infrastructure;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace GotenbergSharpClient.Tests;
@@ -19,7 +20,6 @@ public void PdfPassword_Create_WithValidPassword_ReturnsInstance()
         var password = PdfPassword.Create("secret123");
 
         password.Value.Should().Be("secret123");
-        password.ToString().Should().Be("secret123");
     }
 
     [TestCase(null)]
@@ -43,12 +43,11 @@ public void PdfPassword_Equality_WithSameValue_ReturnsTrue()
     }
 
     [Test]
-    public void PdfPassword_ImplicitConversion_ToStringReturnsValue()
+    public void PdfPassword_ToString_ReturnsRedactedValue()
     {
-        PdfPassword password = PdfPassword.Create("secret");
-        string result = password;
+        var password = PdfPassword.Create("secret");
 
-        result.Should().Be("secret");
+        password.ToString().Should().Be("****");
     }
 
     #endregion
@@ -115,7 +114,7 @@ public async Task UserPassword_SerializesToCorrectHttpContent()
 
         var httpContents = options.ToHttpContent().ToList();
         var content = httpContents.FirstOrDefault(c =>
-            c.Headers.ContentDisposition?.Name == "userPassword");
+            c.Headers.ContentDisposition?.Name == Constants.Gotenberg.PdfOutput.UserPassword);
 
         content.Should().NotBeNull();
         (await content!.ReadAsStringAsync()).Should().Be("openme");
@@ -131,7 +130,7 @@ public async Task OwnerPassword_SerializesToCorrectHttpContent()
 
         var httpContents = options.ToHttpContent().ToList();
         var content = httpContents.FirstOrDefault(c =>
-            c.Headers.ContentDisposition?.Name == "ownerPassword");
+            c.Headers.ContentDisposition?.Name == Constants.Gotenberg.PdfOutput.OwnerPassword);
 
         content.Should().NotBeNull();
         (await content!.ReadAsStringAsync()).Should().Be("editme");
@@ -145,9 +144,9 @@ public void NullPasswords_NotIncludedInHttpContent()
         var httpContents = options.ToHttpContent().ToList();
 
         httpContents.FirstOrDefault(c =>
-            c.Headers.ContentDisposition?.Name == "userPassword").Should().BeNull();
+            c.Headers.ContentDisposition?.Name == Constants.Gotenberg.PdfOutput.UserPassword).Should().BeNull();
         httpContents.FirstOrDefault(c =>
-            c.Headers.ContentDisposition?.Name == "ownerPassword").Should().BeNull();
+            c.Headers.ContentDisposition?.Name == Constants.Gotenberg.PdfOutput.OwnerPassword).Should().BeNull();
     }
 
     #endregion