Tweaks

Jaben · Jaben · commit 5597635a6876 · 2026-03-29T12:27:24.000-04:00
diff --git a/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/CompressionQuality.cs b/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/CompressionQuality.cs
@@ -35,7 +35,7 @@ private CompressionQuality(int value)
 
     public static CompressionQuality Create(int quality)
     {
-        if (quality < MinValue || quality > MaxValue)
+        if (quality is < MinValue or > MaxValue)
             throw new ArgumentOutOfRangeException(
                 nameof(quality),
                 quality,
diff --git a/test/GotenbergSharpClient.Tests/LibreOfficeOptionsTests.cs b/test/GotenbergSharpClient.Tests/LibreOfficeOptionsTests.cs
@@ -265,7 +265,7 @@ private static byte[] CreateMinimalDocx()
     {
         // Minimal valid .docx file (ZIP with minimal content)
         // Using a simple HTML-like approach via a .txt renamed - Gotenberg can handle basic office docs
-        return System.Text.Encoding.UTF8.GetBytes("Hello World - LibreOffice test document");
+        return "Hello World - LibreOffice test document"u8.ToArray();
     }
 
     #endregion
diff --git a/test/GotenbergSharpClient.Tests/PdfEngineOperationsTests.cs b/test/GotenbergSharpClient.Tests/PdfEngineOperationsTests.cs
@@ -220,7 +220,7 @@ private static async Task<byte[]> GenerateTestPdf(Gotenberg.Sharp.API.Client.Got
         var builder = new HtmlRequestBuilder()
             .AddDocument(doc => doc.SetBody("<html><body><h1>Test PDF</h1></body></html>"));
 
-        using var stream = await client.HtmlToPdfAsync(builder);
+        await using var stream = await client.HtmlToPdfAsync(builder);
 
         using var ms = new MemoryStream();
         await stream.CopyToAsync(ms);

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ private CompressionQuality(int value)`
`35`	`35`
`36`	`36`	`public static CompressionQuality Create(int quality)`
`37`	`37`	`{`
`38`		`- if (quality < MinValue \|\| quality > MaxValue)`
	`38`	`+ if (quality is < MinValue or > MaxValue)`
`39`	`39`	`throw new ArgumentOutOfRangeException(`
`40`	`40`	`nameof(quality),`
`41`	`41`	`quality,`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ private static byte[] CreateMinimalDocx()`
`265`	`265`	`{`
`266`	`266`	`// Minimal valid .docx file (ZIP with minimal content)`
`267`	`267`	`// Using a simple HTML-like approach via a .txt renamed - Gotenberg can handle basic office docs`
`268`		`- return System.Text.Encoding.UTF8.GetBytes("Hello World - LibreOffice test document");`
	`268`	`+ return "Hello World - LibreOffice test document"u8.ToArray();`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`#endregion`