Address CodeRabbit nitpick feedback (round 2)

Jaben · Jaben · commit d987f1b028f2 · 2026-03-28T23:15:15.000-04:00
- Make implicit operators on DomainName, GotenbergStatusCode, and
  CssSelector throw ArgumentNullException instead of silently returning
  null/0 — consistent with DDD validation philosophy
- Add null implicit conversion test for GotenbergStatusCode
- Add negative integration test verifying failOnResourceLoadingFailed
  triggers GotenbergApiException when resources fail to load
diff --git a/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/CssSelector.cs b/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/CssSelector.cs
@@ -49,7 +49,9 @@ public static CssSelector Create(string selector)
 
     public override int GetHashCode() => Value.GetHashCode();
 
-    public static implicit operator string(CssSelector selector) => selector?.Value!;
+    /// <exception cref="ArgumentNullException">Thrown when <paramref name="selector"/> is null.</exception>
+    public static implicit operator string(CssSelector selector) =>
+        selector?.Value ?? throw new ArgumentNullException(nameof(selector));
 
     public static bool operator ==(CssSelector? left, CssSelector? right) => Equals(left, right);
 
diff --git a/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/DomainName.cs b/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/DomainName.cs
@@ -50,7 +50,9 @@ public bool Equals(DomainName? other) => other is not null
 
     public override int GetHashCode() => StringComparer.OrdinalIgnoreCase.GetHashCode(Value);
 
-    public static implicit operator string(DomainName domain) => domain?.Value!;
+    /// <exception cref="ArgumentNullException">Thrown when <paramref name="domain"/> is null.</exception>
+    public static implicit operator string(DomainName domain) =>
+        domain?.Value ?? throw new ArgumentNullException(nameof(domain));
 
     public static bool operator ==(DomainName? left, DomainName? right) => Equals(left, right);
 
diff --git a/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/GotenbergStatusCode.cs b/src/Gotenberg.Sharp.Api.Client/Domain/ValueObjects/GotenbergStatusCode.cs
@@ -63,7 +63,9 @@ public static GotenbergStatusCode Create(int statusCode)
 
     public int CompareTo(GotenbergStatusCode? other) => other is null ? 1 : Value.CompareTo(other.Value);
 
-    public static implicit operator int(GotenbergStatusCode code) => code?.Value ?? 0;
+    /// <exception cref="ArgumentNullException">Thrown when <paramref name="code"/> is null.</exception>
+    public static implicit operator int(GotenbergStatusCode code) =>
+        code?.Value ?? throw new ArgumentNullException(nameof(code));
 
     public static bool operator ==(GotenbergStatusCode? left, GotenbergStatusCode? right) => Equals(left, right);
 
diff --git a/test/GotenbergSharpClient.Tests/ChromiumMissingFieldsIntegrationTests.cs b/test/GotenbergSharpClient.Tests/ChromiumMissingFieldsIntegrationTests.cs
@@ -1,6 +1,7 @@
 using Gotenberg.Sharp.API.Client.Domain.Builders;
 using Gotenberg.Sharp.API.Client.Domain.Settings;
 using Gotenberg.Sharp.API.Client.Extensions;
+using Gotenberg.Sharp.API.Client.Infrastructure;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace GotenbergSharpClient.Tests;
@@ -81,6 +82,21 @@ public async Task HtmlToPdf_WithFailOnHttpStatusCodes_Succeeds()
         result.Length.Should().BeGreaterThan(0);
     }
 
+    [Category("Integration")]
+    [Test]
+    public async Task HtmlToPdf_WithFailOnResourceLoadingFailed_WhenResourceFails_Throws()
+    {
+        var builder = new HtmlRequestBuilder()
+            .AddDocument(doc => doc.SetBody(
+                "<html><body><img src='http://192.0.2.1/nonexistent.png'/></body></html>"))
+            .SetConversionBehaviors(b => b
+                .FailOnResourceLoadingFailed());
+
+        var act = async () => await _client.HtmlToPdfAsync(builder);
+
+        await act.Should().ThrowAsync<GotenbergApiException>();
+    }
+
     [Category("Integration")]
     [Test]
     public async Task HtmlToPdf_WithFailOnResourceLoadingFailed_Succeeds()
diff --git a/test/GotenbergSharpClient.Tests/ValueObjects/GotenbergStatusCodeTests.cs b/test/GotenbergSharpClient.Tests/ValueObjects/GotenbergStatusCodeTests.cs
@@ -38,6 +38,16 @@ public void ImplicitConversion_ToIntReturnsValue()
         result.Should().Be(404);
     }
 
+    [Test]
+    public void ImplicitConversion_WithNull_Throws()
+    {
+        GotenbergStatusCode? nullCode = null;
+
+        var act = () => { int _ = nullCode!; };
+
+        act.Should().ThrowExactly<ArgumentNullException>();
+    }
+
     [Test]
     public void Equals_WithSameValue_ReturnsTrue()
     {
