fix UI

Author: zhujian0805

frontend/src/pages/Library.test.tsx

@@ -38,6 +38,21 @@ describe('Library page', () => {
     await waitFor(() => expect(screen.getByText(/golang-testing/i)).toBeInTheDocument())
   })
 
+  it('keeps rendering when search returns a null items payload', async () => {
+    vi.spyOn(api, 'searchMetadata')
+      .mockResolvedValueOnce({ items: [metadataItem({ name: 'initial-skill', kind: 'skill', install_key: 'o/r:initial-skill' })], total: 1, limit: 20, offset: 0 })
+      .mockResolvedValueOnce({ items: null as unknown as MetadataItem[], total: 0, limit: 20, offset: 0 })
+    render(<Library kind="skill" />)
+
+    expect(await screen.findByText(/initial-skill/i)).toBeInTheDocument()
+    fireEvent.change(screen.getByLabelText(/skills search/i), { target: { value: 'zzzz-no-match' } })
+    fireEvent.click(screen.getByRole('button', { name: /search/i }))
+
+    await waitFor(() => expect(screen.getByText(/no skills found/i)).toBeInTheDocument())
+    expect(screen.getByRole('heading', { name: /skills/i })).toBeInTheDocument()
+    vi.restoreAllMocks()
+  })
+
   it('renders subagents page', async () => {
     render(<Library kind="agent" />)
     expect(await screen.findByRole('heading', { name: /subagents/i })).toBeInTheDocument()

frontend/src/pages/Library.tsx

@@ -49,8 +49,8 @@ export function Library({ kind }: LibraryProps) {
     setLoading(true)
     try {
       const resp = await api.searchMetadata(kind, q, PAGE_SIZE, off)
-      setItems(resp.items)
-      setTotal(resp.total)
+      setItems(resp.items ?? [])
+      setTotal(resp.total ?? 0)
       return resp
     } catch (err) {
       setStatus(`Search failed: ${err instanceof Error ? err.message : String(err)}`)
@@ -69,8 +69,9 @@ export function Library({ kind }: LibraryProps) {
   //      self-heal under a purely empty check, because the kind isn't empty.
   const loadOrAutoRefresh = useCallback(async (q: string, off: number) => {
     const resp = await load(q, off)
+    const respItems = resp?.items ?? []
     const isEmpty = !resp || resp.total === 0
-    const isStale = !!resp && resp.items.length > 0 && resp.items.some((item) => !item.install_key.includes(':'))
+    const isStale = respItems.length > 0 && respItems.some((item) => !item.install_key.includes(':'))
     if ((isEmpty || isStale) && q === '' && off === 0 && !autoRefreshed.current) {
       autoRefreshed.current = true
       setRefreshing(true)

internal/metadata/store.go

@@ -271,7 +271,7 @@ func (s *Store) MarkInstalled(ctx context.Context, kind, installKey, targetApp s
 }
 
 func scanItems(rows *sql.Rows) ([]Item, error) {
-	var items []Item
+	items := []Item{}
 	for rows.Next() {
 		var it Item
 		var installed int

internal/metadata/store_test.go

@@ -70,6 +70,28 @@ func TestSearchByKindFilter(t *testing.T) {
 	}
 }
 
+func TestSearchNoMatchesReturnsEmptySlice(t *testing.T) {
+	ctx := context.Background()
+	s := NewStore(filepath.Join(t.TempDir(), "cam.db"))
+	if err := s.Init(ctx); err != nil {
+		t.Fatal(err)
+	}
+	if err := s.UpsertItem(ctx, Item{Kind: "skill", Name: "present", InstallKey: "a/b:present"}); err != nil {
+		t.Fatalf("UpsertItem: %v", err)
+	}
+
+	results, err := s.Search(ctx, SearchQuery{Query: "missing", Kind: "skill"})
+	if err != nil {
+		t.Fatalf("Search: %v", err)
+	}
+	if results == nil {
+		t.Fatal("expected non-nil empty slice for no matches")
+	}
+	if len(results) != 0 {
+		t.Fatalf("expected 0 results, got %d", len(results))
+	}
+}
+
 func TestSearchPagination(t *testing.T) {
 	ctx := context.Background()
 	s := NewStore(filepath.Join(t.TempDir(), "cam.db"))