Expand OpenAI model regression coverage

Add data-driven tests around OpenAI and compat model handling,
including GPT-5 token parameter selection, mapped model values,
and provider boundary behavior.

Also extend predicate and model-name conversion coverage across
completion, Claude, OpenRouter, and AI/ML model-key groups so
future config and mapping regressions fail deterministically.

Author: PeterDaveHello

tests/unit/config/config-predicates.test.mjs

@@ -3,6 +3,11 @@ import { afterEach, beforeEach, describe, test } from 'node:test'
 import {
   getNavigatorLanguage,
   getPreferredLanguageKey,
+  chatgptApiModelKeys,
+  gptApiModelKeys,
+  claudeApiModelKeys,
+  openRouterApiModelKeys,
+  aimlApiModelKeys,
   isUsingAimlApiModel,
   isUsingAzureOpenAiApiModel,
   isUsingBingWebModel,
@@ -19,6 +24,7 @@ import {
   isUsingMultiModeModel,
   isUsingOllamaApiModel,
   isUsingOpenAiApiModel,
+  isUsingGptCompletionApiModel,
   isUsingOpenRouterApiModel,
 } from '../../../src/config/index.mjs'
 
@@ -63,22 +69,42 @@ test('getNavigatorLanguage treats zh-Hant locale as zhHant', () => {
   assert.equal(getNavigatorLanguage(), 'zhHant')
 })
 
-test('isUsingChatgptApiModel detects chatgpt API models and excludes custom model', () => {
+test('isUsingChatgptApiModel matches representative chatgpt API keys', () => {
   assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi4oMini' }), true)
-  assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi5' }), true)
-  assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi5_1' }), true)
   assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi5_2' }), true)
-  assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi5_4' }), true)
   assert.equal(isUsingChatgptApiModel({ modelName: 'customModel' }), false)
 })
 
-test('isUsingOpenAiApiModel accepts both chat and completion API model groups', () => {
+test('isUsingChatgptApiModel accepts exported chatgpt API model keys', () => {
+  for (const modelName of chatgptApiModelKeys) {
+    assert.equal(isUsingChatgptApiModel({ modelName }), true)
+  }
+})
+
+test('isUsingOpenAiApiModel matches representative chat and completion API keys', () => {
   assert.equal(isUsingOpenAiApiModel({ modelName: 'chatgptApi4oMini' }), true)
   assert.equal(isUsingOpenAiApiModel({ modelName: 'gptApiInstruct' }), true)
+  assert.equal(isUsingOpenAiApiModel({ modelName: 'customModel' }), false)
 })
 
-test('isUsingOpenAiApiModel excludes custom model', () => {
-  assert.equal(isUsingOpenAiApiModel({ modelName: 'customModel' }), false)
+test('isUsingOpenAiApiModel accepts exported chat and completion API model groups', () => {
+  for (const modelName of chatgptApiModelKeys) {
+    assert.equal(isUsingOpenAiApiModel({ modelName }), true)
+  }
+  for (const modelName of gptApiModelKeys) {
+    assert.equal(isUsingOpenAiApiModel({ modelName }), true)
+  }
+})
+
+test('isUsingGptCompletionApiModel matches representative completion API keys', () => {
+  assert.equal(isUsingGptCompletionApiModel({ modelName: 'gptApiInstruct' }), true)
+  assert.equal(isUsingGptCompletionApiModel({ modelName: 'chatgptApi4oMini' }), false)
+})
+
+test('isUsingGptCompletionApiModel accepts exported completion API model keys', () => {
+  for (const modelName of gptApiModelKeys) {
+    assert.equal(isUsingGptCompletionApiModel({ modelName }), true)
+  }
 })
 
 test('isUsingCustomModel works with modelName and apiMode forms', () => {
@@ -116,12 +142,17 @@ test('isUsingGeminiWebModel detects bard/gemini web models', () => {
   assert.equal(isUsingGeminiWebModel({ modelName: 'chatgptFree35' }), false)
 })
 
-test('isUsingClaudeApiModel detects Claude API models', () => {
+test('isUsingClaudeApiModel matches representative Claude API keys', () => {
   assert.equal(isUsingClaudeApiModel({ modelName: 'claude37SonnetApi' }), true)
-  assert.equal(isUsingClaudeApiModel({ modelName: 'claudeOpus4Api' }), true)
   assert.equal(isUsingClaudeApiModel({ modelName: 'claude2WebFree' }), false)
 })
 
+test('isUsingClaudeApiModel accepts exported Claude API model keys', () => {
+  for (const modelName of claudeApiModelKeys) {
+    assert.equal(isUsingClaudeApiModel({ modelName }), true)
+  }
+})
+
 test('isUsingMoonshotApiModel detects moonshot API models', () => {
   assert.equal(isUsingMoonshotApiModel({ modelName: 'moonshot_v1_8k' }), true)
   assert.equal(isUsingMoonshotApiModel({ modelName: 'moonshot_k2' }), true)
@@ -134,20 +165,28 @@ test('isUsingDeepSeekApiModel detects DeepSeek models', () => {
   assert.equal(isUsingDeepSeekApiModel({ modelName: 'chatgptApi4oMini' }), false)
 })
 
-test('isUsingOpenRouterApiModel detects OpenRouter models', () => {
-  assert.equal(
-    isUsingOpenRouterApiModel({ modelName: 'openRouter_anthropic_claude_sonnet4' }),
-    true,
-  )
+test('isUsingOpenRouterApiModel matches representative OpenRouter API keys', () => {
   assert.equal(isUsingOpenRouterApiModel({ modelName: 'openRouter_openai_o3' }), true)
   assert.equal(isUsingOpenRouterApiModel({ modelName: 'chatgptApi4oMini' }), false)
 })
 
-test('isUsingAimlApiModel detects AI/ML models', () => {
+test('isUsingOpenRouterApiModel accepts exported OpenRouter API model keys', () => {
+  for (const modelName of openRouterApiModelKeys) {
+    assert.equal(isUsingOpenRouterApiModel({ modelName }), true)
+  }
+})
+
+test('isUsingAimlApiModel matches representative AI/ML API keys', () => {
   assert.equal(isUsingAimlApiModel({ modelName: 'aiml_claude_3_7_sonnet_20250219' }), true)
   assert.equal(isUsingAimlApiModel({ modelName: 'chatgptApi4oMini' }), false)
 })
 
+test('isUsingAimlApiModel accepts exported AI/ML model keys', () => {
+  for (const modelName of aimlApiModelKeys) {
+    assert.equal(isUsingAimlApiModel({ modelName }), true)
+  }
+})
+
 test('isUsingChatGLMApiModel detects ChatGLM models', () => {
   assert.equal(isUsingChatGLMApiModel({ modelName: 'chatglmTurbo' }), true)
   assert.equal(isUsingChatGLMApiModel({ modelName: 'chatglm4' }), true)