Add and refine high-value Node unit tests for core guards

Expand Node unit coverage for config predicates, token-retention
boundaries, port-error handling, and utility guard edge cases.

Refine existing util tests so boundary intent is explicit and easier to
review, while preserving current runtime behavior.

Author: PeterDaveHello

tests/unit/config/config-predicates.test.mjs

@@ -0,0 +1,87 @@
+import assert from 'node:assert/strict'
+import { afterEach, test } from 'node:test'
+import {
+  getNavigatorLanguage,
+  isUsingBingWebModel,
+  isUsingChatgptApiModel,
+  isUsingCustomModel,
+  isUsingMultiModeModel,
+  isUsingOpenAiApiModel,
+} from '../../../src/config/index.mjs'
+
+const originalNavigatorDescriptor = Object.getOwnPropertyDescriptor(globalThis, 'navigator')
+
+const restoreNavigator = () => {
+  if (originalNavigatorDescriptor) {
+    Object.defineProperty(globalThis, 'navigator', originalNavigatorDescriptor)
+  } else {
+    delete globalThis.navigator
+  }
+}
+
+const setNavigatorLanguage = (language) => {
+  Object.defineProperty(globalThis, 'navigator', {
+    value: { language },
+    configurable: true,
+  })
+}
+
+afterEach(() => {
+  restoreNavigator()
+})
+
+test('getNavigatorLanguage returns zhHant for zh-TW style locales', () => {
+  setNavigatorLanguage('zh-TW')
+  assert.equal(getNavigatorLanguage(), 'zhHant')
+})
+
+test('getNavigatorLanguage returns first two letters for non-zhHant locales', () => {
+  setNavigatorLanguage('en-US')
+  assert.equal(getNavigatorLanguage(), 'en')
+})
+
+test('getNavigatorLanguage normalizes mixed-case zh-TW locale to zhHant', () => {
+  setNavigatorLanguage('ZH-TW')
+  assert.equal(getNavigatorLanguage(), 'zhHant')
+})
+
+test('getNavigatorLanguage treats zh-Hant locale as zhHant', () => {
+  setNavigatorLanguage('zh-Hant')
+  assert.equal(getNavigatorLanguage(), 'zhHant')
+})
+
+test('isUsingChatgptApiModel detects chatgpt API models and excludes custom model', () => {
+  assert.equal(isUsingChatgptApiModel({ modelName: 'chatgptApi4oMini' }), true)
+  assert.equal(isUsingChatgptApiModel({ modelName: 'customModel' }), false)
+})
+
+test('isUsingOpenAiApiModel accepts both chat and completion API model groups', () => {
+  assert.equal(isUsingOpenAiApiModel({ modelName: 'chatgptApi4oMini' }), true)
+  assert.equal(isUsingOpenAiApiModel({ modelName: 'gptApiInstruct' }), true)
+})
+
+test('isUsingOpenAiApiModel excludes custom model', () => {
+  assert.equal(isUsingOpenAiApiModel({ modelName: 'customModel' }), false)
+})
+
+test('isUsingCustomModel works with modelName and apiMode forms', () => {
+  assert.equal(isUsingCustomModel({ modelName: 'customModel' }), true)
+
+  const apiMode = {
+    groupName: 'customApiModelKeys',
+    itemName: 'customModel',
+    isCustom: true,
+    customName: 'my-custom-model',
+    customUrl: '',
+    apiKey: '',
+    active: true,
+  }
+  assert.equal(isUsingCustomModel({ apiMode }), true)
+})
+
+test('isUsingMultiModeModel currently follows Bing web group behavior', () => {
+  assert.equal(isUsingBingWebModel({ modelName: 'bingFree4' }), true)
+  assert.equal(isUsingMultiModeModel({ modelName: 'bingFree4' }), true)
+  assert.equal(isUsingBingWebModel({ modelName: 'chatgptFree35' }), false)
+  assert.equal(isUsingMultiModeModel({ modelName: 'chatgptFree35' }), false)
+})

tests/unit/config/user-config.test.mjs

@@ -0,0 +1,90 @@
+import assert from 'node:assert/strict'
+import { beforeEach, test } from 'node:test'
+import { clearOldAccessToken, getUserConfig, setAccessToken } from '../../../src/config/index.mjs'
+
+const THIRTY_DAYS_MS = 30 * 24 * 3600 * 1000
+
+beforeEach(() => {
+  globalThis.__TEST_BROWSER_SHIM__.clearStorage()
+})
+
+test('getUserConfig migrates legacy chat.openai.com URL to chatgpt.com', async () => {
+  globalThis.__TEST_BROWSER_SHIM__.replaceStorage({
+    customChatGptWebApiUrl: 'https://chat.openai.com',
+  })
+
+  const config = await getUserConfig()
+
+  assert.equal(config.customChatGptWebApiUrl, 'https://chatgpt.com')
+})
+
+test('getUserConfig keeps modern chatgpt.com URL unchanged', async () => {
+  globalThis.__TEST_BROWSER_SHIM__.replaceStorage({
+    customChatGptWebApiUrl: 'https://chatgpt.com',
+  })
+
+  const config = await getUserConfig()
+
+  assert.equal(config.customChatGptWebApiUrl, 'https://chatgpt.com')
+})
+
+test('clearOldAccessToken clears expired token older than 30 days', async (t) => {
+  const now = 1_700_000_000_000
+  t.mock.method(Date, 'now', () => now)
+
+  globalThis.__TEST_BROWSER_SHIM__.replaceStorage({
+    accessToken: 'stale-token',
+    tokenSavedOn: now - THIRTY_DAYS_MS - 1_000,
+  })
+
+  await clearOldAccessToken()
+
+  const storage = globalThis.__TEST_BROWSER_SHIM__.getStorage()
+  assert.equal(storage.accessToken, '')
+  // tokenSavedOn write behavior is covered in the dedicated setAccessToken test below.
+})
+
+test('setAccessToken updates tokenSavedOn to Date.now', async (t) => {
+  const now = 1_700_000_000_000
+  t.mock.method(Date, 'now', () => now)
+
+  await setAccessToken('new-token')
+
+  const storage = globalThis.__TEST_BROWSER_SHIM__.getStorage()
+  assert.equal(storage.accessToken, 'new-token')
+  assert.equal(storage.tokenSavedOn, now)
+})
+
+test('clearOldAccessToken keeps recent token within 30 days', async (t) => {
+  const now = 1_700_000_000_000
+  t.mock.method(Date, 'now', () => now)
+  const recentSavedOn = now - THIRTY_DAYS_MS + 1_000
+
+  globalThis.__TEST_BROWSER_SHIM__.replaceStorage({
+    accessToken: 'fresh-token',
+    tokenSavedOn: recentSavedOn,
+  })
+
+  await clearOldAccessToken()
+
+  const storage = globalThis.__TEST_BROWSER_SHIM__.getStorage()
+  assert.equal(storage.accessToken, 'fresh-token')
+  assert.equal(storage.tokenSavedOn, recentSavedOn)
+})
+
+test('clearOldAccessToken keeps token when exactly 30 days old', async (t) => {
+  const now = 1_700_000_000_000
+  t.mock.method(Date, 'now', () => now)
+  const savedOn = now - THIRTY_DAYS_MS
+
+  globalThis.__TEST_BROWSER_SHIM__.replaceStorage({
+    accessToken: 'boundary-token',
+    tokenSavedOn: savedOn,
+  })
+
+  await clearOldAccessToken()
+
+  const storage = globalThis.__TEST_BROWSER_SHIM__.getStorage()
+  assert.equal(storage.accessToken, 'boundary-token')
+  assert.equal(storage.tokenSavedOn, savedOn)
+})

tests/unit/services/apis/openai-api-compat.test.mjs

@@ -79,6 +79,210 @@ test('generateAnswersWithChatgptApiCompat sends expected request and aggregates
   assert.deepEqual(session.conversationRecords.at(-1), { question: 'CurrentQ', answer: 'Hello' })
 })
 
+test('generateAnswersWithChatgptApiCompat uses max_completion_tokens for OpenAI gpt-5 models', async (t) => {
+  t.mock.method(console, 'debug', () => {})
+  setStorage({
+    maxConversationContextLength: 3,
+    maxResponseTokenLength: 321,
+    temperature: 0.2,
+  })
+
+  const session = {
+    modelName: 'chatgptApi-gpt-5.1-chat-latest',
+    conversationRecords: [],
+    isRetry: false,
+  }
+  const port = createFakePort()
+
+  let capturedInit
+  t.mock.method(globalThis, 'fetch', async (_input, init) => {
+    capturedInit = init
+    return createMockSseResponse([
+      'data: {"choices":[{"delta":{"content":"OK"},"finish_reason":"stop"}]}\n\n',
+    ])
+  })
+
+  await generateAnswersWithChatgptApiCompat(
+    'https://api.example.com/v1',
+    port,
+    'CurrentQ',
+    session,
+    'sk-test',
+    {},
+    'openai',
+  )
+
+  const body = JSON.parse(capturedInit.body)
+  assert.equal(body.max_completion_tokens, 321)
+  assert.equal(Object.hasOwn(body, 'max_tokens'), false)
+})
+
+test('generateAnswersWithChatgptApiCompat removes conflicting token key from extraBody', async (t) => {
+  t.mock.method(console, 'debug', () => {})
+  setStorage({
+    maxConversationContextLength: 3,
+    maxResponseTokenLength: 222,
+    temperature: 0.2,
+  })
+
+  const session = {
+    modelName: 'chatgptApi4oMini',
+    conversationRecords: [],
+    isRetry: false,
+  }
+  const port = createFakePort()
+
+  let capturedInit
+  t.mock.method(globalThis, 'fetch', async (_input, init) => {
+    capturedInit = init
+    return createMockSseResponse([
+      'data: {"choices":[{"delta":{"content":"OK"},"finish_reason":"stop"}]}\n\n',
+    ])
+  })
+
+  await generateAnswersWithChatgptApiCompat(
+    'https://api.example.com/v1',
+    port,
+    'CurrentQ',
+    session,
+    'sk-test',
+    {
+      max_completion_tokens: 999,
+      top_p: 0.9,
+    },
+  )
+
+  const body = JSON.parse(capturedInit.body)
+  assert.equal(body.max_tokens, 222)
+  assert.equal(Object.hasOwn(body, 'max_completion_tokens'), false)
+  assert.equal(body.top_p, 0.9)
+})
+
+test('generateAnswersWithChatgptApiCompat removes max_tokens from extraBody for OpenAI gpt-5 models', async (t) => {
+  t.mock.method(console, 'debug', () => {})
+  setStorage({
+    maxConversationContextLength: 3,
+    maxResponseTokenLength: 500,
+    temperature: 0.2,
+  })
+
+  const session = {
+    modelName: 'chatgptApi-gpt-5.1-chat-latest',
+    conversationRecords: [],
+    isRetry: false,
+  }
+  const port = createFakePort()
+
+  let capturedInit
+  t.mock.method(globalThis, 'fetch', async (_input, init) => {
+    capturedInit = init
+    return createMockSseResponse([
+      'data: {"choices":[{"delta":{"content":"OK"},"finish_reason":"stop"}]}\n\n',
+    ])
+  })
+
+  await generateAnswersWithChatgptApiCompat(
+    'https://api.example.com/v1',
+    port,
+    'CurrentQ',
+    session,
+    'sk-test',
+    {
+      max_tokens: 999,
+      top_p: 0.8,
+    },
+    'openai',
+  )
+
+  const body = JSON.parse(capturedInit.body)
+  assert.equal(body.max_completion_tokens, 500)
+  assert.equal(Object.hasOwn(body, 'max_tokens'), false)
+  assert.equal(body.top_p, 0.8)
+})
+
+test('generateAnswersWithChatgptApiCompat allows max_tokens override for compat provider', async (t) => {
+  t.mock.method(console, 'debug', () => {})
+  setStorage({
+    maxConversationContextLength: 3,
+    maxResponseTokenLength: 400,
+    temperature: 0.2,
+  })
+
+  const session = {
+    modelName: 'chatgptApi4oMini',
+    conversationRecords: [],
+    isRetry: false,
+  }
+  const port = createFakePort()
+
+  let capturedInit
+  t.mock.method(globalThis, 'fetch', async (_input, init) => {
+    capturedInit = init
+    return createMockSseResponse([
+      'data: {"choices":[{"delta":{"content":"OK"},"finish_reason":"stop"}]}\n\n',
+    ])
+  })
+
+  await generateAnswersWithChatgptApiCompat(
+    'https://api.example.com/v1',
+    port,
+    'CurrentQ',
+    session,
+    'sk-test',
+    {
+      max_tokens: 333,
+      top_p: 0.75,
+    },
+  )
+
+  const body = JSON.parse(capturedInit.body)
+  assert.equal(body.max_tokens, 333)
+  assert.equal(Object.hasOwn(body, 'max_completion_tokens'), false)
+  assert.equal(body.top_p, 0.75)
+})
+
+test('generateAnswersWithChatgptApiCompat allows max_completion_tokens override for OpenAI gpt-5 models', async (t) => {
+  t.mock.method(console, 'debug', () => {})
+  setStorage({
+    maxConversationContextLength: 3,
+    maxResponseTokenLength: 400,
+    temperature: 0.2,
+  })
+
+  const session = {
+    modelName: 'chatgptApi-gpt-5.1-chat-latest',
+    conversationRecords: [],
+    isRetry: false,
+  }
+  const port = createFakePort()
+
+  let capturedInit
+  t.mock.method(globalThis, 'fetch', async (_input, init) => {
+    capturedInit = init
+    return createMockSseResponse([
+      'data: {"choices":[{"delta":{"content":"OK"},"finish_reason":"stop"}]}\n\n',
+    ])
+  })
+
+  await generateAnswersWithChatgptApiCompat(
+    'https://api.example.com/v1',
+    port,
+    'CurrentQ',
+    session,
+    'sk-test',
+    {
+      max_completion_tokens: 333,
+      top_p: 0.65,
+    },
+    'openai',
+  )
+
+  const body = JSON.parse(capturedInit.body)
+  assert.equal(body.max_completion_tokens, 333)
+  assert.equal(Object.hasOwn(body, 'max_tokens'), false)
+  assert.equal(body.top_p, 0.65)
+})
+
 test('generateAnswersWithChatgptApiCompat throws on non-ok response with JSON error body', async (t) => {
   t.mock.method(console, 'debug', () => {})
   setStorage({