fix: hotfix for v3.17.0 set maximum of goroutines#296
Closed
cx-rogerio-dalot wants to merge 5 commits intorelease/v3.17.0from
Closed
fix: hotfix for v3.17.0 set maximum of goroutines#296cx-rogerio-dalot wants to merge 5 commits intorelease/v3.17.0from
cx-rogerio-dalot wants to merge 5 commits intorelease/v3.17.0from
Conversation
|
Policy Management Violations (1)
|
cx-rogerio-dalot
force-pushed
the
AST-99769-thread-exhaustion-error-in-2-ms
branch
from
a71d70c to
a95cd85
Compare
cx-rogerio-dalot
changed the title
<!-- Thanks for contributing to 2ms by offering a pull request. --> Closes # **Proposed Changes** <!-- Please describe the big picture of your changes here. If it fixes a bug or resolves a feature request, be sure to link to that issue. --> **Checklist** - [ ] I covered my changes with tests. - [ ] I Updated the documentation that is affected by my changes: - [ ] Change in the CLI arguments - [ ] Change in the configuration file I submit this contribution under the Apache-2.0 license. --------- Co-authored-by: cx-leonardo-fontes <204389152+cx-leonardo-fontes@users.noreply.github.com>
cx-rogerio-dalot
force-pushed
the
AST-99769-thread-exhaustion-error-in-2-ms
branch
4 times, most recently
from
14a1c4f to
b1a77a1
Compare
cx-rogerio-dalot
force-pushed
the
AST-99769-thread-exhaustion-error-in-2-ms
branch
from
b1a77a1 to
da1764d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The binary as is can take the process to resource exhaustion due to going over the limit of 10k goroutines.
This is a quickfix/hotfix and in no case sustainable for the future, we need indeed to refactor our current implementation but it should solve the issue for now.
Checklist
I submit this contribution under the Apache-2.0 license.