Skip to content

feat: add limits fields to scan config #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-leonardo-fontes merged 3 commits into from
Jan 23, 2026
Merged

feat: add limits fields to scan config #369

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d848c7
add limits fields to scan config
cx-leonardo-fontes Jan 23, 2026
6bcba0a
handle linter issues
cx-leonardo-fontes Jan 23, 2026
ebeaefb
update test assert to be more accurate
cx-leonardo-fontes Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/resources/scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,9 @@ type ScanConfig struct {
CustomRules []*ruledefine.Rule
WithValidation bool
PluginName string

// Limit settings
MaxFindings uint64 // Total findings limit across entire scan (0 = no limit)
MaxRuleMatchesPerFragment uint64 // Regex matches limit per rule per fragment (0 = no limit)
MaxSecretSize uint64 // Maximum secret size in bytes (0 = no limit)
}
21 changes: 12 additions & 9 deletions pkg/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,28 +33,31 @@ func NewScanner() Scanner {
return &scanner{}
}

func (s *scanner) Reset(scanConfig resources.ScanConfig, opts ...engine.EngineOption) error {
func (s *scanner) Reset(scanConfig *resources.ScanConfig, opts ...engine.EngineOption) error {
s.mu.Lock()
defer s.mu.Unlock()

engineInstance, err := engine.Init(&engine.EngineConfig{
IgnoredIds: scanConfig.IgnoreResultIds,
SelectedList: scanConfig.SelectRules,
CustomRules: scanConfig.CustomRules,
IgnoreList: scanConfig.IgnoreRules,
ScanConfig: scanConfig,
IgnoredIds: scanConfig.IgnoreResultIds,
SelectedList: scanConfig.SelectRules,
CustomRules: scanConfig.CustomRules,
IgnoreList: scanConfig.IgnoreRules,
MaxFindings: scanConfig.MaxFindings,
MaxRuleMatchesPerFragment: scanConfig.MaxRuleMatchesPerFragment,
MaxSecretSize: scanConfig.MaxSecretSize,
ScanConfig: *scanConfig,
}, opts...)
if err != nil {
return fmt.Errorf("error initializing engine: %w", err)
}

s.engineInstance = engineInstance
s.scanConfig = scanConfig
s.scanConfig = *scanConfig

return nil
}

func (s *scanner) Scan(scanItems []ScanItem, scanConfig resources.ScanConfig, opts ...engine.EngineOption) (reporting.IReport, error) {
func (s *scanner) Scan(scanItems []ScanItem, scanConfig *resources.ScanConfig, opts ...engine.EngineOption) (reporting.IReport, error) {
var wg conc.WaitGroup
err := s.Reset(scanConfig, opts...)
if err != nil {
Expand Down Expand Up @@ -106,7 +109,7 @@ func (s *scanner) Scan(scanItems []ScanItem, scanConfig resources.ScanConfig, op

func (s *scanner) ScanDynamic(
itemsIn <-chan ScanItem,
scanConfig resources.ScanConfig,
scanConfig *resources.ScanConfig,
opts ...engine.EngineOption,
) (reporting.IReport, error) {
var wg conc.WaitGroup
Expand Down
Loading
Loading