Skip to content

fix: move ScanConfig to public package#370

Merged
cx-leonardo-fontes merged 2 commits intomasterfrom
Fix-Scan-Config-Inside-Internal-Pkg
Jan 23, 2026
Merged

fix: move ScanConfig to public package#370
cx-leonardo-fontes merged 2 commits intomasterfrom
Fix-Scan-Config-Inside-Internal-Pkg

Conversation

@cx-leonardo-fontes
Copy link
Copy Markdown
Contributor

@cx-leonardo-fontes cx-leonardo-fontes commented Jan 23, 2026 •
edited
Loading

  • Moved ScanConfig from internal/resources to pkg/scanner (public API)
  • Replaced nested EngineConfig.ScanConfig.WithValidation with direct EngineConfig.WithValidation field

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 23, 2026

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 16
Files parsed placeholder 16
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@cx-leonardo-fontes cx-leonardo-fontes changed the title fix struct from public interface in an internal package and removed nested ScanConfig inside EngineConfig fix struct used as parameter in public interface defined in an internal package and removed nested ScanConfig inside EngineConfig Jan 23, 2026
@cx-leonardo-fontes cx-leonardo-fontes changed the title fix struct used as parameter in public interface defined in an internal package and removed nested ScanConfig inside EngineConfig fix: struct used as parameter in public interface defined in an internal package and removed nested ScanConfig inside EngineConfig Jan 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 23, 2026 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 8fd7122e-d7c3-4bb3-a7c6-a944ab6a0857

Great job! No new security vulnerabilities introduced in this pull request

@cx-leonardo-fontes cx-leonardo-fontes changed the title fix: struct used as parameter in public interface defined in an internal package and removed nested ScanConfig inside EngineConfig fix: parameter in public interface defined in an internal package and nested ScanConfig inside EngineConfig Jan 23, 2026
@cx-leonardo-fontes cx-leonardo-fontes changed the title fix: parameter in public interface defined in an internal package and nested ScanConfig inside EngineConfig fix: parameter from public interface defined in an internal package and nested ScanConfig inside EngineConfig Jan 23, 2026
@cx-leonardo-fontes cx-leonardo-fontes changed the title fix: parameter from public interface defined in an internal package and nested ScanConfig inside EngineConfig fix: move ScanConfig to public package Jan 23, 2026
@cx-leonardo-fontes cx-leonardo-fontes marked this pull request as ready for review January 23, 2026 15:57
@cx-leonardo-fontes cx-leonardo-fontes requested a review from a team as a code owner January 23, 2026 15:57
@cx-leonardo-fontes cx-leonardo-fontes merged commit dc0d9ab into master Jan 23, 2026
12 of 17 checks passed
@cx-leonardo-fontes cx-leonardo-fontes deleted the Fix-Scan-Config-Inside-Internal-Pkg branch January 23, 2026 16:07
@BrewTestBot BrewTestBot mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-diogo-rocha cx-diogo-rocha cx-diogo-rocha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-leonardo-fontes @cx-diogo-rocha