Skip to content

fix: updated GCP validation to always consider 403 response as valid result #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-diogo-rocha merged 4 commits into from
Apr 17, 2026
+3 −4
Merged

fix: updated GCP validation to always consider 403 response as valid result #383

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a6596e
Updated gcp validation to always consider 403 as valid result (only 4…
cx-diogo-rocha Apr 16, 2026
ea04532
Updated images in docker and go version
cx-diogo-rocha Apr 16, 2026
d3df370
Fix linter issue
cx-diogo-rocha Apr 16, 2026
72529d6
Merge branch 'master' of https://github.com/Checkmarx/2ms into AST-14…
cx-diogo-rocha Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions engine/validation/gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,14 @@ func checkGCPErrorResponse(resp *http.Response) (secrets.ValidationResult, strin
return secrets.UnknownResult, "", err
}

extra := ""
if strings.Contains(errorResponse.Error.Message, "YouTube Data API v3 has not been used in project") {
extra := ""
for _, detail := range errorResponse.Error.Details {
if detail.Type == "type.googleapis.com/google.rpc.ErrorInfo" {
extra = detail.Metadata.Consumer
}
}
return secrets.ValidResult, extra, nil
}

return secrets.UnknownResult, "", nil
// if resp.StatusCode is StatusForbidden, it indicates the secret is valid, but just not allowed for Youtube API
return secrets.ValidResult, extra, nil
}
Loading