Removed validate() method to allow the use of EnvVars for the plugins. (#133)

* Removed the validate() that checks for presence of base url and credentials.

* Updated version of slf4j-simple to satisfy Enforcer rule in Jenkins plugin.

Author: Mithilesh Pawar

pom.xml

@@ -48,7 +48,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-simple</artifactId>
-            <version>1.7.25</version>
+            <version>1.7.30</version>
         </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>

src/main/java/com/checkmarx/ast/wrapper/CxConfig.java

@@ -5,15 +5,14 @@
 import lombok.Data;
 import lombok.Setter;
 import org.apache.commons.lang3.StringUtils;
-
 import java.util.ArrayList;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 @Data
 @Builder
-public class  CxConfig {
+public class CxConfig {
 
     private static final Pattern pattern = Pattern.compile("([^\"]\\S*|\".+?\")\\s*");
 
@@ -31,17 +30,6 @@ public void setAdditionalParameters(String additionalParameters) {
         this.additionalParameters = parseAdditionalParameters(additionalParameters);
     }
 
-    void validate() throws InvalidCLIConfigException {
-        if (StringUtils.isBlank(getBaseUri())) {
-            throw new InvalidCLIConfigException("Checkmarx server URL is not set");
-        }
-
-        if (StringUtils.isBlank(getApiKey())
-            && (StringUtils.isBlank(getClientId()) || StringUtils.isBlank(getClientSecret()))) {
-            throw new InvalidCLIConfigException("Credentials are not set");
-        }
-    }
-
     List<String> toArguments() {
         List<String> commands = new ArrayList<>();
 

src/main/java/com/checkmarx/ast/wrapper/CxWrapper.java

@@ -42,7 +42,6 @@ public CxWrapper(CxConfig cxConfig)
 
     public CxWrapper(@NonNull CxConfig cxConfig, @NonNull Logger logger) throws CxConfig.InvalidCLIConfigException,
             IOException {
-        cxConfig.validate();
         this.cxConfig = cxConfig;
         this.logger = logger;
         this.executable = StringUtils.isBlank(this.cxConfig.getPathToExecutable())
@@ -305,7 +304,7 @@ public int getResultsBfl(@NonNull UUID scanId, @NonNull String queryId, List<Nod
 
     }
 
-    public kicsRealtimeResults kicsRealtimeScan(@NonNull String fileSources,String engine ,String additionalParams)
+    public kicsRealtimeResults kicsRealtimeScan(@NonNull String fileSources, String engine, String additionalParams)
             throws IOException, InterruptedException, CxException {
         this.logger.info("Executing 'scan kics-realtime' command using the CLI.");
         this.logger.info("Fetching the results for fileSources {} and additionalParams {}", fileSources, additionalParams);
@@ -317,14 +316,15 @@ public kicsRealtimeResults kicsRealtimeScan(@NonNull String fileSources,String e
         arguments.add(fileSources);
         arguments.add(CxConstants.ADDITONAL_PARAMS);
         arguments.add(additionalParams);
-        if(engine.length()>0){
+        if (engine.length() > 0) {
             arguments.add(CxConstants.ENGINE);
             arguments.add(engine);
         }
         kicsRealtimeResults kicsResults = Execution.executeCommand(withConfigArguments(arguments), logger, kicsRealtimeResults::fromLine);
         return kicsResults;
 
     }
+
     private int getIndexOfBfLNode(List<Node> bflNodes, List<Node> resultNodes) {
 
         int bflNodeNotFound = -1;