- Added error check for value as empty in case of empty value

- Fixed unit tests

Author: cx-anjali-deore

internal/commands/root.go

@@ -461,6 +461,9 @@ func extractOptionalFlags(cmd *cobra.Command) error {
 		if len(keyVal) != params.KeyValuePairSize {
 			return errors.New("Invalid optional flags. Optional flags should be in a KEY1=VALUE1;KEY2=VALUE2 format")
 		}
+		if strings.TrimSpace(keyVal[1]) == "" {
+			return errors.New("Invalid optional flags. Value for key " + keyVal[0] + " is empty")
+		}
 		err := utils.SetOptionalParam(keyVal[0], keyVal[1])
 		if err != nil {
 			return err

internal/wrappers/utils/utils.go

@@ -54,7 +54,7 @@ func SetOptionalParam(key, value string) error {
 	if _, ok := allowedOptionalKeys[key]; ok {
 		optionalParams[key] = value
 	} else {
-		return errors.New("Invalid optional parameter key: " + key)
+		return errors.New("Invalid optional flags parameter key: " + key)
 	}
 	return nil
 }

internal/wrappers/utils/utils_test.go

@@ -198,7 +198,7 @@ func TestSetNotAllowedKeyDoesNotSet(t *testing.T) {
 	value := "value"
 
 	err := SetOptionalParam(key, value)
-	assert.Nil(t, err)
+	assert.NotNil(t, err)
 
 	if hasOptionalParam(key) {
 		t.Fatalf("expected hasOptionalParam(%q) to be false for disallowed key", key)